fix(react-spinbutton): fix read-only functionality#35761
Open
dmytrokirpa wants to merge 2 commits intomicrosoft:masterfrom
Open
fix(react-spinbutton): fix read-only functionality#35761dmytrokirpa wants to merge 2 commits intomicrosoft:masterfrom
dmytrokirpa wants to merge 2 commits intomicrosoft:masterfrom
Conversation
dmytrokirpa
requested review from
a team and
ValentinaKozlova
as code owners
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Positioning 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 745 | Changed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
When the
readOnlyprop is applied toSpinButton, users are unable to enter a new value using the up or down buttons. However, pressing the up or down arrow buttons or keyboard keys still changes the value.New Behavior
When the
readOnlyprop is applied toSpinButton, the up and down buttons are disabled, and pressing the up or down keys on the keyboard has no effect.Related Issue(s)