chore(react-tabster): upgrade tabster to 8.6.2#35552
Open
bsunderhus wants to merge 4 commits intomicrosoft:masterfrom
Open
chore(react-tabster): upgrade tabster to 8.6.2#35552bsunderhus wants to merge 4 commits intomicrosoft:masterfrom
bsunderhus wants to merge 4 commits intomicrosoft:masterfrom
Conversation
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,204 @@ | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Charts-DonutChart 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic - Dark Mode.default.chromium.png | 12638 | Changed |
| vr-tests-react-components/Charts-DonutChart.Dynamic.default.chromium.png | 27057 | Changed |
vr-tests-react-components/Drawer 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Drawer.overlay drawer full.chromium.png | 3314 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 80 | Changed |
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 906 | Changed |
vr-tests-react-components/TagPicker 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - High Contrast.chromium.png | 1319 | Changed |
vr-tests-web-components/Accordion 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Accordion. - Dark Mode.normal.chromium_1.png | 3154 | Changed |
vr-tests-web-components/Avatar 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Avatar. - Dark Mode.normal.chromium.png | 10380 | Changed |
| vr-tests-web-components/Avatar. - Dark Mode.normal.chromium_1.png | 298 | Changed |
vr-tests-web-components/Badge 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Badge. - Dark Mode.normal.chromium.png | 443 | Changed |
vr-tests-web-components/MenuList 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/MenuList. - Dark Mode.normal.chromium.png | 498 | Changed |
| vr-tests-web-components/MenuList. - RTL.2nd selected.chromium.png | 17 | Changed |
| vr-tests-web-components/MenuList. - RTL.normal.chromium_1.png | 39083 | Changed |
vr-tests-web-components/TextInput 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/TextInput. - Dark Mode.normal.chromium_1.png | 288 | Changed |
vr-tests/Callout 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/Callout.Left bottom edge.default.chromium.png | 3182 | Changed |
| vr-tests/Callout.Right center.default.chromium.png | 2117 | Changed |
| vr-tests/Callout.Top auto edge.default.chromium.png | 2212 | Changed |
| vr-tests/Callout.Top center.default.chromium.png | 2127 | Changed |
vr-tests/Keytip 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/Keytip.Offset.default.chromium.png | 86 | Changed |
vr-tests/react-charting-AreaChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-AreaChart.Custom Accessibility.default.chromium.png | 11 | Changed |
vr-tests/react-charting-GaugeChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-GaugeChart.Basic.default.chromium.png | 2 | Changed |
vr-tests/react-charting-LineChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-LineChart.Events - Dark Mode.default.chromium.png | 16 | Changed |
vr-tests/react-charting-MultiStackBarChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-MultiStackBarChart.Basic_PartToWhole - Dark Mode.default.chromium.png | 363 | Changed |
There were 1 duplicate changes discarded. Check the build logs for more information.
📊 Bundle size report
Unchanged fixtures
|
bsunderhus
force-pushed
the
chore(react-tabster)--upgrate-tabster-version-to-8.6.2
branch
from
240309c to
edb678a
Compare
tudorpopams
approved these changes
Dec 10, 2025
- Upgrades tabster from 8.5.5 to 8.6.2 - Includes fix for GitHub issue microsoft#35520 where down arrow in combobox within table would move focus to next table cell instead of navigating combobox options - The upgrade includes tabster PR microsoft#486 which adds combobox role to elements ignored by Mover when aria-expanded=true feat(react-table): add integration test for combobox keyboard navigation fix - Adds cypress test to verify fix for issue microsoft#35520 - Tests that down arrow in open combobox updates aria-activedescendant instead of moving to table cell - Verifies combobox functionality is preserved within table grid navigation context - Uses real @fluentui/react-components Combobox component for accurate behavior testing Fixes microsoft#35520
bsunderhus
force-pushed
the
chore(react-tabster)--upgrate-tabster-version-to-8.6.2
branch
from
edb678a to
468283d
Compare
Hotell
reviewed
Dec 23, 2025
Hotell
reviewed
Dec 30, 2025
| "@fluentui/scripts-api-extractor": "*", | ||
| "@fluentui/scripts-cypress": "*" | ||
| "@fluentui/scripts-cypress": "*", | ||
| "@fluentui/react-combobox": "*" |
Contributor
There was a problem hiding this comment.
this isn't necessary as this package is explicitly imported thus part of nx dependency graph. please remove - this will also remove need of change file for react-table
layershifter
approved these changes
Jan 5, 2026
…94e.json Co-authored-by: Martin Hochel <hochelmartin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(react-table): add integration test for combobox keyboard navigation fix
Fixes #35520