[dev-v5] Add the DataGrid ODataAdapter and EntityFrameworkAdapter packages#4901
Open
vnbaaij wants to merge 4 commits into
Open
[dev-v5] Add the DataGrid ODataAdapter and EntityFrameworkAdapter packages#4901vnbaaij wants to merge 4 commits into
vnbaaij wants to merge 4 commits into
Conversation
8 tasks
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 98.7%
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds two new DataGrid adapter extension packages (Entity Framework Core and OData Client) that provide IAsyncQueryExecutor implementations so FluentDataGrid can execute queries asynchronously for those providers, plus related dependency and documentation updates.
Changes:
- Introduces
Microsoft.FluentUI.AspNetCore.Components.DataGrid.EntityFrameworkAdapterand...DataGrid.ODataAdapterextension packages (executors + DI registration). - Makes
IAsyncQueryExecutorpublic to support external adapter packages/consumers. - Updates repository docs, solution registration, and centralized package versions for new dependencies.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Extensions/no-file.txt | Removes temporary placeholder file from Extensions folder. |
| src/Extensions/DataGrid.ODataAdapter/README.md | Adds usage/install docs for the OData DataGrid adapter. |
| src/Extensions/DataGrid.ODataAdapter/ODataAsyncQueryExecutor.cs | Adds OData IAsyncQueryExecutor implementation. |
| src/Extensions/DataGrid.ODataAdapter/ODataAdapterServiceCollectionExtensions.cs | Adds DI registration extension for the OData executor. |
| src/Extensions/DataGrid.ODataAdapter/Microsoft.FluentUI.AspNetCore.Components.DataGrid.ODataAdapter.csproj | Adds new OData adapter package project. |
| src/Extensions/DataGrid.EntityFrameworkAdapter/README.md | Adds usage/install docs for the EF Core DataGrid adapter. |
| src/Extensions/DataGrid.EntityFrameworkAdapter/Properties/launchSettings.json | Adds a launch profile for the EF adapter project. |
| src/Extensions/DataGrid.EntityFrameworkAdapter/Microsoft.FluentUI.AspNetCore.Components.DataGrid.EntityFrameworkAdapter.csproj | Adds new EF adapter package project and dependencies. |
| src/Extensions/DataGrid.EntityFrameworkAdapter/EntityFrameworkAsyncQueryExecutor.cs | Adds EF Core IAsyncQueryExecutor implementation. |
| src/Extensions/DataGrid.EntityFrameworkAdapter/EntityFrameworkAdapterServiceCollectionExtensions.cs | Adds DI registration extension for the EF executor. |
| src/Core/Components/DataGrid/Infrastructure/IAsyncQueryExecutor.cs | Changes IAsyncQueryExecutor from internal to public API. |
| README.md | Updates baseline .NET requirement and adds EF adapter guidance. |
| Microsoft.FluentUI-v5.slnx | Registers the new extension projects in the solution. |
| Directory.Packages.props | Adds centralized versions for OData Client + MemoryCache. |
Comment on lines
+45
to
+52
| catch (ObjectDisposedException) | ||
| { | ||
| return default!; | ||
| } | ||
| catch (Exception ex) when (ignoreException?.Invoke(ex) == true) | ||
| { | ||
| return default!; | ||
| } |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the DataGrid ODataAdapter and EntityFrameworkAdapter packages. Also updated documentation and package dependencies, and makes some minor codebase improvements.
New DataGrid Entity Framework Adapter
Added a new package,
Microsoft.FluentUI.AspNetCore.Components.DataGrid.EntityFrameworkAdapter, which provides anIAsyncQueryExecutorimplementation for Entity Framework Core. This enables the DataGrid to efficiently handle asynchronous queries with EF Core.Added a new package,
Microsoft.FluentUI.AspNetCore.Components.DataGrid.ODataAdapter, which provides anIAsyncQueryExecutorimplementation for OData sources. This enables the DataGrid to efficiently handle working with an OData source.Registered the new adapter in the solution and updated the main solution file to include them.
Dependency Updates
Microsoft.OData.ClientandMicrosoft.Extensions.Caching.Memoryto the shared package dependencies inDirectory.Packages.props, ensuring these libraries are available for projects that need them.Documentation Improvements
README.mdto:Codebase Improvements
IAsyncQueryExecutorfrominternaltopublicto allow use by the new adapter package and other consumers.