Skip to content

chore: add tests for no item repeat binding#7238

Merged
janechu merged 3 commits into
mainfrom
users/radium-v/repeat-markers
Feb 17, 2026
Merged

chore: add tests for no item repeat binding#7238
janechu merged 3 commits into
mainfrom
users/radium-v/repeat-markers

Conversation

@radium-v
Copy link
Copy Markdown
Collaborator

@radium-v radium-v commented Dec 9, 2025

Pull Request

📖 Description

Adds test coverage for a hydrating repeat directive (f-repeat) that has no items in its initial state. This addresses a hydration scenario where empty repeats need proper hydration markers to bind correctly during client-side activation.

🎫 Issues

📑 Test Plan

Added a new test case repeat directive with no item binding should not error that:

  • Verifies an empty repeat renders with no list items
  • Confirms hydrated comment nodes are present in the shadow DOM after hydration
  • Tests that items can be dynamically added after hydration

✅ Checklist

General

  • I have included a change request file using $ npm run change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

⏭ Next Steps

While the hydration markers documentation in RENDERING.md mentions this quirk, the document should describe this and other scenarios more clearly.

@radium-v radium-v force-pushed the users/radium-v/repeat-markers branch from e092476 to eb5d87a Compare December 12, 2025 16:33
@radium-v radium-v force-pushed the users/radium-v/repeat-markers branch from eb5d87a to f8120d2 Compare January 7, 2026 17:42
@radium-v radium-v force-pushed the users/radium-v/repeat-markers branch from b1625e9 to bfa330d Compare February 11, 2026 16:41
@janechu janechu merged commit ec73f27 into main Feb 17, 2026
9 of 14 checks passed
@janechu janechu deleted the users/radium-v/repeat-markers branch February 17, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(fast-html): a hydrating repeat with no items has no hydration markers

3 participants