test: add recordings for new cp tests#153
Open
v-alexmoraru wants to merge 17 commits intomicrosoft:mainfrom
Open
test: add recordings for new cp tests#153v-alexmoraru wants to merge 17 commits intomicrosoft:mainfrom
v-alexmoraru wants to merge 17 commits intomicrosoft:mainfrom
Conversation
ohadedry
reviewed
Feb 18, 2026
| # Teardown: remove everything we created during the test | ||
| for metadata in created_virtual_workspace_items: | ||
| if vcr_mode == "none" and metadata.type == VirtualWorkspaceType.CAPACITY: | ||
| continue |
Contributor
There was a problem hiding this comment.
Can you please explain this change?
Member
Author
There was a problem hiding this comment.
The teardown would otherwise fail for capacities, this was the only workaround I could find
Contributor
There was a problem hiding this comment.
Don't we want to clean Capacity that was created during the test?
Why the teardown will fail?
ayeshurun
reviewed
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.