Use fixed-width ASCII checkbox markers - #939
Conversation
stdmnpkg
left a comment
stdmnpkg
left a comment
There was a problem hiding this comment.
this also improve usability on terminal with only ASCII font
following picture is current situation, "match case" and "use regex" is unchecked, "whole word" is checked
| self.attr_reverse(); | ||
| } | ||
| self.styled_label_add_text(if *checked { "[◼ " } else { "[◻ " }); | ||
| self.styled_label_add_text(if *checked { "[x] " } else { "[ ] " }); |
I mean we both know an LLM created this. And in most parts of the world, LLM output is not copyrightable, but public domain. You cannot claim it as "your work" because legally speaking, a "work" is generally understood as something that is copyrightable. So, your series of PRs do not constitute a "work". |
Leonard Hecker (lhecker)
left a comment
Leonard Hecker (lhecker)
left a comment
There was a problem hiding this comment.
Can you please name terminals where the current use of glyphs is an issue?
After all, this application also uses "…" in menu items, which is also ambiguous width.
QmlTermWidget based terminal had issue align box border due to use of I'd suggest accept this, at least for usability on ASCII only environment. |
|
While I'm open to improving support for important terminals, such as the Linux Console, I'm not eager to improve support for rare terminals such as QmlTermWidget. This is because broad support for old or primitive terminals requires complexity in the TUI design that I'd like to avoid. The Linux Console is a good example for that since almost anything more complex than a modal editor like It is similar when it comes to using non-ASCII glyphs. Should we support systems that do not support Unicode glyphs? Maybe we shouldn't. |
3 participants
Summary
[ ]and[x]markersValidation
cargo test --all-features --all-targetson Windows and WSL/Ubuntucargo clippy --workspace --all-features --all-targets -- --no-deps --deny warningson Windows and WSL/UbuntuContribution ownership
This contribution is entirely my own work. It is not created on behalf of, or connected with, any organization or company. I agree to contribute it under the repository's MIT License and to the repository's applicable contribution terms.