Skip to content

Revert "Add large payload support (#272)"#277

Merged
bachuv merged 2 commits intomainfrom
vabachu/revert-large-payload
Apr 7, 2026
Merged

Revert "Add large payload support (#272)"#277
bachuv merged 2 commits intomainfrom
vabachu/revert-large-payload

Conversation

@bachuv
Copy link
Copy Markdown
Contributor

@bachuv bachuv commented Apr 6, 2026

This reverts commit 34780a9. This feature will get added again once autochunking improvements are made.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes are added to the CHANGELOG.md
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

Copilot AI review requested due to automatic review settings April 6, 2026 22:39
@bachuv bachuv requested a review from a team as a code owner April 6, 2026 22:39
YunchuWang
YunchuWang previously approved these changes Apr 6, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts the previously-added “large payload support” feature (PR #272) across the Java SDK, removing the blob-backed payload externalization module and all related client/worker/runtime hooks.

Changes:

  • Removes the azure-blob-payloads module and its ServiceLoader-based provider wiring.
  • Deletes large-payload APIs/helpers (e.g., PayloadStore, LargePayloadOptions) and removes payload interception/chunking logic from client and azurefunctions.
  • Removes unit + integration tests that validated large payload externalization behavior.

Reviewed changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
settings.gradle Removes :azure-blob-payloads from the Gradle multi-project build.
client/src/main/java/com/microsoft/durabletask/DurableTaskGrpcWorkerBuilder.java Reverts builder fields/methods for large payload externalization and response chunk sizing.
client/src/main/java/com/microsoft/durabletask/DurableTaskGrpcWorker.java Removes payload resolution/externalization, capability announcement, and orchestrator-response chunking behavior.
client/src/main/java/com/microsoft/durabletask/DurableTaskGrpcClientBuilder.java Removes client builder configuration for payload externalization.
client/src/main/java/com/microsoft/durabletask/DurableTaskGrpcClient.java Removes client-side payload externalization and metadata payload resolution logic.
client/src/main/java/com/microsoft/durabletask/OrchestrationRunner.java Removes overloads that accepted a PayloadStore / LargePayloadOptions and strips request/response payload interception.
azurefunctions/src/main/java/com/microsoft/durabletask/azurefunctions/internal/middleware/OrchestrationMiddleware.java Removes PayloadStoreProvider discovery and stops passing a payload store into OrchestrationRunner.
client/src/main/java/com/microsoft/durabletask/LargePayloadOptions.java Deletes large payload threshold/max configuration type.
client/src/main/java/com/microsoft/durabletask/PayloadHelper.java Deletes helper that externalized/resolved payloads based on thresholds.
client/src/main/java/com/microsoft/durabletask/PayloadInterceptionHelper.java Deletes protobuf interception logic for resolving/externalizing payload fields.
client/src/main/java/com/microsoft/durabletask/PayloadStore.java Deletes payload store abstraction interface.
client/src/main/java/com/microsoft/durabletask/PayloadStoreProvider.java Deletes SPI for discovering PayloadStore implementations.
client/src/main/java/com/microsoft/durabletask/PayloadTooLargeException.java Deletes exception used for max-payload enforcement and chunking errors.
client/src/test/java/com/microsoft/durabletask/DurableTaskGrpcWorkerBuilderTest.java Removes tests for chunk size validation and payload-store builder configuration.
client/src/test/java/com/microsoft/durabletask/LargePayloadIntegrationTests.java Removes end-to-end integration tests for large payloads + autochunk scenarios.
client/src/test/java/com/microsoft/durabletask/LargePayloadOptionsTest.java Removes unit tests for large payload option validation/defaults.
client/src/test/java/com/microsoft/durabletask/OrchestrationRunnerPayloadTest.java Removes runner tests covering payload resolution/externalization paths.
client/src/test/java/com/microsoft/durabletask/PayloadHelperTest.java Removes unit tests for thresholding and token resolution logic.
client/src/test/java/com/microsoft/durabletask/PayloadInterceptionHelperTest.java Removes unit tests for protobuf payload interception behavior.
azure-blob-payloads/build.gradle Deletes the module build definition and Azure SDK dependencies.
azure-blob-payloads/spotbugs-exclude.xml Removes SpotBugs exclusions for the deleted module.
azure-blob-payloads/src/main/resources/META-INF/services/com.microsoft.durabletask.PayloadStoreProvider Removes ServiceLoader registration for the blob payload store provider.
azure-blob-payloads/src/main/java/com/microsoft/durabletask/azureblobpayloads/AzureBlobPayloadsExtensions.java Deletes builder extension helpers for enabling blob payload externalization.
azure-blob-payloads/src/main/java/com/microsoft/durabletask/azureblobpayloads/BlobPayloadStore.java Deletes Azure Blob Storage implementation of PayloadStore.
azure-blob-payloads/src/main/java/com/microsoft/durabletask/azureblobpayloads/BlobPayloadStoreOptions.java Deletes blob store configuration options type.
azure-blob-payloads/src/main/java/com/microsoft/durabletask/azureblobpayloads/BlobPayloadStoreProvider.java Deletes env-var driven provider that enabled blob payload externalization.
azure-blob-payloads/src/test/java/com/microsoft/durabletask/azureblobpayloads/BlobPayloadStoreOptionsTest.java Deletes unit tests for blob store options validation/defaults.

@bachuv bachuv merged commit e32d47c into main Apr 7, 2026
8 checks passed
@bachuv bachuv deleted the vabachu/revert-large-payload branch April 7, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants