Skip to content

Devirtualize storage hot path: mark MemoryStorage/OfflineStorageHandler final + TU-local statics #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmehta001 wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Devirtualize storage hot path: mark MemoryStorage/OfflineStorageHandler final + TU-local statics #1488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5d12da4
devirt: mark concrete leaf impl classes final
bmehta001 Jun 18, 2026
d0c0afb
Internal linkage: mark TU-local C-API helpers and DllMain global static
bmehta001 Jun 19, 2026
693926c
Fix typo in capi.cpp comment: Marashal -> Marshal
bmehta001 Jun 24, 2026
0094b32
Merge branch 'main' into bhamehta/devirt-final-static
bmehta001 Jun 30, 2026
4f1718e
Narrow scope: keep 'final' only where it measurably devirtualizes
bmehta001 Jun 30, 2026
9b250ee
Drop redundant virtual on non-override methods in final storage classes
bmehta001 Jun 30, 2026
777bff0
Merge branch 'main' into bhamehta/devirt-final-static
bmehta001 Jul 1, 2026
0159528
Merge branch 'main' into bhamehta/devirt-final-static
bmehta001 Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions lib/api/capi.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ capi_client * MAT::capi_get_client(evt_handle_t handle)
/// <summary>
/// Remove C API handle from active client tracking struct.
/// </summary>
void remove_client(evt_handle_t handle)
static void remove_client(evt_handle_t handle)
{
LOCKGUARD(mtx);
clients.erase(handle);
Expand All @@ -66,7 +66,7 @@ void remove_client(evt_handle_t handle)
return ENOENT; \
};

evt_status_t mat_open_core(
static evt_status_t mat_open_core(
evt_context_t *ctx,
const char* config,
http_send_fn_t httpSendFn,
Expand Down Expand Up @@ -175,7 +175,7 @@ evt_status_t mat_open_core(
return ctx->result;
}

evt_status_t mat_open(evt_context_t *ctx)
static evt_status_t mat_open(evt_context_t *ctx)
{
if (ctx == nullptr)
{
Expand All @@ -186,7 +186,7 @@ evt_status_t mat_open(evt_context_t *ctx)
return mat_open_core(ctx, config, nullptr, nullptr, nullptr, nullptr, nullptr);
}

evt_status_t mat_open_with_params(evt_context_t *ctx)
static evt_status_t mat_open_with_params(evt_context_t *ctx)
{
if (ctx == nullptr)
{
Expand Down Expand Up @@ -231,9 +231,9 @@ evt_status_t mat_open_with_params(evt_context_t *ctx)
}

/**
* Marashal C struct to C++ API
* Marshal C struct to C++ API
*/
evt_status_t mat_log(evt_context_t *ctx)
static evt_status_t mat_log(evt_context_t *ctx)
Comment thread
bmehta001 marked this conversation as resolved.
{
VERIFY_CLIENT_HANDLE(client, ctx);

Expand Down Expand Up @@ -285,7 +285,7 @@ evt_status_t mat_log(evt_context_t *ctx)
return ctx->result;
}

evt_status_t mat_close(evt_context_t *ctx)
static evt_status_t mat_close(evt_context_t *ctx)
{
VERIFY_CLIENT_HANDLE(client, ctx);
const auto result = static_cast<evt_status_t>(LogManagerProvider::Release(client->logmanager->GetLogConfiguration()));
Expand All @@ -305,31 +305,31 @@ evt_status_t mat_close(evt_context_t *ctx)
return result;
}

evt_status_t mat_pause(evt_context_t *ctx)
static evt_status_t mat_pause(evt_context_t *ctx)
{
VERIFY_CLIENT_HANDLE(client, ctx);
const auto result = static_cast<evt_status_t>(client->logmanager->PauseTransmission());
ctx->result = result;
return result;
}

evt_status_t mat_resume(evt_context_t *ctx)
static evt_status_t mat_resume(evt_context_t *ctx)
{
VERIFY_CLIENT_HANDLE(client, ctx);
const auto result = static_cast<evt_status_t>(client->logmanager->ResumeTransmission());
ctx->result = result;
return result;
}

evt_status_t mat_upload(evt_context_t *ctx)
static evt_status_t mat_upload(evt_context_t *ctx)
{
VERIFY_CLIENT_HANDLE(client, ctx);
const auto result = static_cast<evt_status_t>(client->logmanager->UploadNow());
ctx->result = result;
return result;
}

evt_status_t mat_flushAndTeardown(evt_context_t *ctx)
static evt_status_t mat_flushAndTeardown(evt_context_t *ctx)
{
VERIFY_CLIENT_HANDLE(client, ctx);
client->logmanager->FlushAndTeardown();
Expand Down
4 changes: 2 additions & 2 deletions lib/offline/MemoryStorage.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

namespace MAT_NS_BEGIN {

class MemoryStorage : public IOfflineStorage
class MemoryStorage final : public IOfflineStorage
{

public:
Expand Down Expand Up @@ -69,7 +69,7 @@ namespace MAT_NS_BEGIN {

virtual size_t GetRemainingRecordCountForShutdown() const override;

virtual size_t GetReservedCount();
size_t GetReservedCount();

virtual std::vector<StorageRecord> GetRecords(bool shutdown = false, EventLatency minLatency = EventLatency_Unspecified, unsigned maxCount = 0) override;

Expand Down
6 changes: 3 additions & 3 deletions lib/offline/OfflineStorageHandler.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

namespace MAT_NS_BEGIN {

class OfflineStorageHandler : public IOfflineStorage, public IOfflineStorageObserver
class OfflineStorageHandler final : public IOfflineStorage, public IOfflineStorageObserver
{
public:
OfflineStorageHandler(ILogManager& logManager, IRuntimeConfig& runtimeConfig, ITaskDispatcher& taskDispatcher);
Expand Down Expand Up @@ -64,7 +64,7 @@ namespace MAT_NS_BEGIN {
virtual void OnStorageRecordsSaved(size_t numRecords) override;

protected:
virtual void DeleteRecordsByKeys(const std::list<std::string> & keys);
void DeleteRecordsByKeys(const std::list<std::string> & keys);

IOfflineStorageObserver * m_observer;
ILogManager & m_logManager;
Expand All @@ -75,7 +75,7 @@ namespace MAT_NS_BEGIN {
KillSwitchManager m_killSwitchManager;
ClockSkewManager m_clockSkewManager;

virtual bool isKilled(StorageRecord const& record);
bool isKilled(StorageRecord const& record);

std::mutex m_flushLock;
bool m_flushPending;
Expand Down
2 changes: 1 addition & 1 deletion lib/shared/dllmain.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#ifdef _MANAGED
#pragma unmanaged
#endif
unsigned thread_count = 0;
static unsigned thread_count = 0;

BOOL APIENTRY DllMain(HMODULE /* hModule */, DWORD ul_reason_for_call, LPVOID /* lpReserved */)
{
Expand Down
Loading