fix: Deserialization issue#481
Merged
Prajwal-Microsoft merged 1 commit intopsl-cps-v2from Mar 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request improves the serialization of processed output in the
GapExecutorto handle Python datetime objects, preventing serialization errors during workflow execution. It also adds comprehensive unit tests to ensure datetime values are correctly serialized.Serialization improvements:
_json_defaultmethod toGapExecutorto convertdatetime,date, andtimeobjects to ISO format strings for JSON serialization, and updated the serialization logic in_serialize_processed_outputto use this method. This prevents failures when serializing processed output containing these types. [1] [2] [3]Testing enhancements:
TestSerializeProcessedOutputtest class to verify thatGapExecutor._serialize_processed_outputcorrectly serializes dictionaries containing nesteddatetimevalues. [1] [2]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information