fix(kmod-nvidia-open): move driver version from package name into Version field#18108
Open
ellie-di wants to merge 1 commit into
Open
fix(kmod-nvidia-open): move driver version from package name into Version field#18108ellie-di wants to merge 1 commit into
ellie-di wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Moves the NVIDIA driver version from the kmod package name into its RPM version to establish a stable package name.
Changes:
- Renames the subpackage and assigns driver/kernel NVR fields.
- Keys configuration and license paths by kernel version.
- Bumps the kernel release and refreshes generated metadata.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
base/comps/kernel/kmod-nvidia-open.inc |
Updates source kmod packaging. |
base/comps/kernel/kernel.comp.toml |
Bumps kernel package release. |
specs/k/kernel/kmod-nvidia-open.inc |
Updates rendered kmod include. |
specs/k/kernel/kernel.azl.macros |
Updates generated release macro. |
locks/kernel.lock |
Refreshes component fingerprint. |
Comment on lines
+24
to
+27
| %package -n kmod-%{_kmod_name} | ||
| Summary: NVIDIA open GPU kernel modules (driver %{nvidia_open_version}) | ||
| Version: %{nvidia_open_version} | ||
| Release: %{_azl_kver}.%{_azl_krel} |
| [components.kernel.build.defines] | ||
| # RPM release number for the Azure Linux kernel package | ||
| azl_pkgrelease = "5" | ||
| azl_pkgrelease = "6" |
| %package -n kmod-%{_kmod_name} | ||
| Summary: NVIDIA open GPU kernel modules (driver %{nvidia_open_version}) | ||
| Version: %{nvidia_open_version} | ||
| Release: %{_azl_kver}.%{_azl_krel} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the NVIDIA open GPU kmod subpackage from
kmod-nvidia-open-<driver_version>to plain
kmod-nvidia-open, moving the NVIDIA driver version out of the RPM nameand into the RPM Version field. The kernel NVR is used as the Release.
Why
Encoding the driver version in the package name meant every driver bump created a new
package name (
kmod-nvidia-open-595.58.03→kmod-nvidia-open-596.x.y). This breaksdnf:
bump isn't seen as an upgrade of the existing kmod.
Requires: kmod-nvidia-open-595.58.03,a name that disappears on the next driver release, breaking anything that referenced it.
Putting the driver version in
Version:keeps the name (kmod-nvidia-open) stable acrossdriver updates: dnf sees bumps as normal version upgrades, and consumers depend on the
stable name (or on
Provides: nvidia-open-kmod-version/nvidia-kmodto pin a specificdriver version) without breakage.
What changed
kmod-nvidia-open-%{nvidia_open_version}package renamed tokmod-nvidia-open.%{KVERREL}(not the driver version)azl_pkgrelease, re-rendered spec, refreshed lock.Documentation
Follows the out-of-tree kmod packaging strategy documented in #18064.