Skip to content

fix(phpunit): add Fedora 43 stage-1 compatibility fixes#18107

Open
miz060 wants to merge 6 commits into
4.0from
mitchzhu/f43-phpunit-stage1-pins
Open

fix(phpunit): add Fedora 43 stage-1 compatibility fixes#18107
miz060 wants to merge 6 commits into
4.0from
mitchzhu/f43-phpunit-stage1-pins

Conversation

@miz060

@miz060 miz060 commented Jul 23, 2026

Copy link
Copy Markdown
Member

Apply targeted compatibility fixes needed to build and test the existing PHP/PHPUnit component generation against the Fedora 43 stage-1 dependencies.

These changes retain PHPUnit 13.0 and code-coverage 13, use upstream fixes where available, and avoid unavailable dependency pins or mirror injections.

Change list:

  • Backport corrected PHP test requirements for code-coverage12 and type6.
  • Update comparator8 to 8.1.4 for compatibility with Fedora diff8 8.3.
  • Add a focused stage-1 smoke test for code-coverage13 while preserving the full upstream test suite with compatible PHPUnit versions.
  • Backport PHPUnit's diff8 configuration and conditionally exclude comparator-output assertions when stage 1 provides comparator 8.1.2.

Validation:

  • Independent stage-1 builds passed for all six touched components
  • PME prod build passed

Copilot AI review requested due to automatic review settings July 23, 2026 23:29

This comment was marked as outdated.

@miz060 miz060 closed this Jul 23, 2026
@miz060 miz060 reopened this Jul 23, 2026
@miz060
miz060 force-pushed the mitchzhu/f43-phpunit-stage1-pins branch from 3408ec7 to c2e0204 Compare July 24, 2026 00:21
Copilot AI review requested due to automatic review settings July 24, 2026 00:21

This comment was marked as outdated.

Copilot AI review requested due to automatic review settings July 24, 2026 00:44
@miz060
miz060 force-pushed the mitchzhu/f43-phpunit-stage1-pins branch from c2e0204 to 1989d6f Compare July 24, 2026 00:44

This comment was marked as outdated.

@microsoft microsoft deleted a comment from github-actions Bot Jul 24, 2026
@miz060 miz060 changed the title fix(phpunit): pin Fedora stage-1 test dependency stack fix(phpunit): add Fedora 43 stage-1 compatibility fixes Jul 24, 2026
miz060 added 4 commits July 24, 2026 00:59
PHPUnit 12.5.24 treats incomplete PHP version constraints as runner issues, causing %check to exit non-zero after the suite completes.

Backport upstream's complete 8.1.0 and 8.2.0 requirements without changing the package runtime API.

Signed-off-by: Mitch Zhu <mitchzhu@microsoft.com>
The Fedora stage-1 PHPUnit 13.1 runner initializes code-coverage 14 color APIs before loading the test bootstrap, so it cannot execute the code-coverage 13 suite.

Retain the full suite with PHPUnit 13.0 and use a direct installed-API smoke test for the incompatible stage-1 runner without changing the code-coverage 13 API.

Signed-off-by: Mitch Zhu <mitchzhu@microsoft.com>
Comparator 8.0.0 tests fail against PME's diff 8.3 because expected output does not account for the newer diff behavior.

Update to upstream comparator 8.1.4, which retains the same dependency majors and adds diff 8.3 compatibility.

Signed-off-by: Mitch Zhu <mitchzhu@microsoft.com>
PHPUnit 12.5.24 reports type6's incomplete PHP 8.2 constraints as runner issues, causing %check to exit non-zero.

Backport upstream's version-constraint correction without changing the type6 runtime API.

Signed-off-by: Mitch Zhu <mitchzhu@microsoft.com>
Copilot AI review requested due to automatic review settings July 24, 2026 01:01
@miz060
miz060 force-pushed the mitchzhu/f43-phpunit-stage1-pins branch from 1989d6f to 4ca66bc Compare July 24, 2026 01:01
@microsoft microsoft deleted a comment from github-actions Bot Jul 24, 2026
@miz060
miz060 marked this pull request as ready for review July 24, 2026 01:02
@miz060
miz060 requested a review from a team as a code owner July 24, 2026 01:02

This comment was marked as outdated.

miz060 added 2 commits July 24, 2026 01:14
PHPUnit 13.0.5 diff assertions fail against PME's comparator 8.1.2 and diff 8.3 output.

Backport upstream diff8 configuration and conditionally exclude comparator-output assertion classes only with the older buildroot comparator; comparator 8.1.4 restores the full suite automatically.

Signed-off-by: Mitch Zhu <mitchzhu@microsoft.com>
Comparator 8.1.4 requires sebastian/diff 8.3 or newer, while Azure Linux still rendered diff 8.0.0.

Update diff8 to Fedora 8.3.0 so the Azure Linux runtime package set satisfies comparator's dependency and matches the PME stage-1 stack.

Signed-off-by: Mitch Zhu <mitchzhu@microsoft.com>
Copilot AI review requested due to automatic review settings July 24, 2026 01:15
@miz060
miz060 force-pushed the mitchzhu/f43-phpunit-stage1-pins branch from 4ca66bc to 7f19fe9 Compare July 24, 2026 01:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 25 out of 31 changed files in this pull request and generated no new comments.

@reubeno

reubeno commented Jul 24, 2026

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
3 pipeline(s) were filtered out due to trigger conditions.

@christopherco

Copy link
Copy Markdown
Collaborator

@miz060 scratch build check is failing on php-sebastian-comparator8 and phpunit13. Can you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants