fix(libjcat): pin f43 0.2.6 to fix pkcs7-self-signed-pq-gnutls %check failure#18106
Open
WithEnoughCoffee wants to merge 1 commit into
Open
fix(libjcat): pin f43 0.2.6 to fix pkcs7-self-signed-pq-gnutls %check failure#18106WithEnoughCoffee wants to merge 1 commit into
WithEnoughCoffee wants to merge 1 commit into
Conversation
… failure Pin libjcat to Fedora f43 commit 2ea787b (0.2.6, 2026-04-14). In 0.2.6 the pkcs7-self-signed-pq-gnutls self-test skips (instead of failing) when the system crypto-policy cannot enable ML-DSA-87 at runtime — the failure seen on AZL4 with GnuTLS 3.8.13. The default AZL4 Fedora 43 snapshot (2026-02-24) predates this commit, so the build otherwise stays on 0.2.5 and fails. Per-component snapshot overrides are not allowed, so spec.upstream-commit is used (takes priority over the global snapshot). Moved from an inline entry in components.toml to a dedicated .comp.toml with rationale. Upstream fixes: hughsie/libjcat 156f0101, 5de47e86, 1952439e (issue microsoft#195). https://src.fedoraproject.org/rpms/libjcat/c/2ea787baf270ee42d43911b0b06dc0ea4a997179?branch=f43
Contributor
Author
|
/azp run |
|
Azure Pipelines: 3 pipeline(s) were filtered out due to trigger conditions. |
Contributor
There was a problem hiding this comment.
Pull request overview
Pins libjcat to Fedora 43’s 0.2.6 release, allowing unsupported ML-DSA tests to skip instead of failing.
Changes:
- Moves libjcat to a dedicated pinned component definition.
- Updates the lock file and rendered package to 0.2.6.
- Regenerates the source checksum and changelog.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
base/comps/libjcat/libjcat.comp.toml |
Defines and documents the Fedora commit pin. |
base/comps/components.toml |
Removes the former unmodified inline entry. |
locks/libjcat.lock |
Locks the selected Fedora commit. |
specs/l/libjcat/libjcat.spec |
Renders version 0.2.6 and its changelog. |
specs/l/libjcat/sources |
Updates the source archive checksum. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The AZL4
libjcat%checkbuild fails in thepkcs7-self-signed-pq-gnutlsself-test: on AZL4 (GnuTLS 3.8.13) the system crypto-policy cannot enable ML-DSA-87 at runtime, and libjcat 0.2.5 aborts viag_assert_no_error.The global Fedora 43 snapshot is frozen at 2026-02-24, so
azldev comp updatealone stays on 0.2.5. This pins libjcat to Fedora f432ea787b(0.2.6) viaspec.upstream-commit, matching the existing per-component pin pattern.Why this is the correct fix (not a test disable)
0.2.6 is an upstream self-skip: when the signature can't be created/verified because ML-DSA isn't available, the test now calls
g_test_skip("ML-MDA cannot be enabled at runtime, skipping")instead of asserting. 0.2.5 lacked this guard. This is upstream behavior, not a downstream test removal.156f0101,5de47e86,1952439e(issue Adding a missing '%{?dist}' tag. #195).Changes
base/comps/libjcat/libjcat.comp.tomlpinningupstream-commit = 2ea787b…, with rationale and a# TODO:to drop the pin once the global snapshot advances past 2026-04-14 (same convention asgolang.comp.toml).[components.libjcat]entry fromcomponents.toml.locks/libjcat.lockand renderedspecs/l/libjcat/(Version 0.2.5→0.2.6, updatedsourcesSHA512).Validation
azldev comp update→changed=0 upToDate=1;render→CHANGED=false(CI-consistent).meson testpasses (PQ test skips cleanly);jcat-toolreports 0.2.6; libraries resolve in mock.