chore: remove 'default-distro' from object model 'distribution' object#18071
chore: remove 'default-distro' from object model 'distribution' object#18071ddstreet wants to merge 1 commit into
Conversation
The 'distribution' object is informational, not a configuration object. The correct place for configuration of the project's default distribution version is inside the project configuration. This places it in the correct object model location in our repo, but doesn't fix the 'azldev' tool.
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Moves the default distribution version into project configuration.
Changes:
- Sets Azure Linux 4.0 Stage 2 as the project default.
- Removes distribution-level default versions.
- Deletes the obsolete Stage 2 override file.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
base/project.toml |
Adds the default distribution version. |
distro/azurelinux.distro.toml |
Removes the Azure Linux default version. |
distro/fedora.distro.toml |
Removes the Fedora default version. |
distro/stage2.toml |
Deletes the redundant override. |
reubeno
left a comment
There was a problem hiding this comment.
These are a part of the existing configurational model; we can't remove them like this.
If you are instead claiming that you don't want them to be, then that's another story.
Can you elaborate on why you are stating this can't be done? The documentation for the The documentation for the Are you saying that there is something using the I'm just trying to understand what/where this might cause a problem, since it seems like - from the docs as well as our current config - it should be ok? My intention here is to keep the |
The 'distribution' object is informational, not a configuration object. The correct place for configuration of the project's default distribution version is inside the project configuration.
This places it in the correct object model location in our repo, but doesn't fix the 'azldev' tool.