Skip to content

ci: allow forbidden-word check bypass label#1398

Open
IEvangelist wants to merge 1 commit into
mainfrom
dapine/forbidden-word-override
Open

ci: allow forbidden-word check bypass label#1398
IEvangelist wants to merge 1 commit into
mainfrom
dapine/forbidden-word-override

Conversation

@IEvangelist

Copy link
Copy Markdown
Member

Summary

  • bypass forbidden-word enforcement when a maintainer applies the ci:skip-forbidden-words label
  • rerun the required check when labels are added or removed
  • publish an empty findings artifact while bypassed so the suggestion workflow remains quiet

This addresses false positives such as the intentional terminology fixtures and matching patterns in #1397.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 75803994-3eea-47f7-ae25-92f4314a019b
Copilot AI review requested due to automatic review settings July 23, 2026 13:31
@IEvangelist IEvangelist added the ci:skip-forbidden-words Allows maintainers to bypass false positives in the forbidden-word check. label Jul 23, 2026
@IEvangelist IEvangelist removed the ci:skip-forbidden-words Allows maintainers to bypass false positives in the forbidden-word check. label Jul 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the “Forbidden Words” GitHub Actions workflow to allow maintainers to bypass the forbidden-word enforcement by applying a dedicated label, while ensuring the required check re-evaluates when labels change.

Changes:

  • Re-triggers the workflow on labeled/unlabeled PR events so the check status reflects label-based bypass changes immediately.
  • Adds a ci:skip-forbidden-words label bypass that skips checkout/scan and exits successfully.
  • When bypassed, emits an empty findings.json and still uploads the findings artifact so downstream suggestion workflows remain quiet.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aspire-repo-bot

Copy link
Copy Markdown
Contributor

Frontend HTML artifact ready

The latest frontend build uploaded the frontend-dist artifact for PR #1398. Use the VS Code button below to open this PR with GitHub Artifacts Explorer and browse the built HTML locally.

VS Code: Open PR #1398 artifacts

This comment updates automatically when a new frontend build artifact is uploaded.

@JamesNK JamesNK left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

Workflow source reviewed: microsoft/aspire.dev PR base main through head d7ae23cfc2a51aea97864e09ddabf563d667fa22.

Phase A — Claim verification

No Aspire product or API claims were added. The sole changed file is .github/workflows/forbidden-words.yml, and the label-bypass workflow logic has no correctness, security, or required-check issue requiring changes.

Phase B — Documentation test report

Focus area: Not applicable (workflow-only change)

  • Routes exercised: None; no documentation pages or sections changed.
  • Critical issues: 0
  • Warnings: 0
  • Passed checks: Not applicable
  • Recommendations: None
  • Knowledge gaps: None

The documentation site was not started or built because this PR has no user-facing documentation changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants