Python: fix: handle case-insensitive User-Agent headers - #8555
Closed
spark (spark-328) wants to merge 1 commit into
Closed
spark (spark-328) wants to merge 1 commit into
spark (spark-328) wants to merge 1 commit into
Conversation
spark (spark-328)
had a problem deploying
to
github-app-auth
September 20, 2026 10:12 — with 
GitHub Actions
Error
GitHub Actions
Error
agent-framework-automation
Bot
added
the
python
github-actions
Bot
changed the title
Author
|
Closing: this duplicates the earlier linked PR #8521. I missed that cross-reference during issue triage and will not continue with duplicate work. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation directly addresses the duplicate-header issue with focused regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes case-insensitive User-Agent handling while preserving header spelling and in-place mutation.
Changes:
- Finds existing User-Agent keys case-insensitively.
- Adds regression coverage for lowercase headers.
| File | Description |
|---|---|
python/packages/core/agent_framework/_telemetry.py |
Updates User-Agent lookup and mutation logic. |
python/packages/core/tests/core/test_telemetry.py |
Tests lowercase User-Agent handling. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8520.
What changed
Validation
uv run pytest packages/core/tests/core/test_telemetry.py -q(38 passed, 1 skipped)uv run ruff check ...