Skip to content

Python: accept int timeouts in A2AAgent - #8516

Open
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
microsoft:mainfrom
ManoharPaturi:fix/a2a-int-timeout
Open

Python: accept int timeouts in A2AAgent#8516
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
microsoft:mainfrom
ManoharPaturi:fix/a2a-int-timeout

Conversation

@ManoharPaturi

@ManoharPaturi Manohar Paturi (ManoharPaturi) commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Motivation & Context

Fixes #8515. A2AAgent(timeout=30) raised TypeError because the guard only allowed float and httpx.Timeout. ints are valid timeouts for httpx itself and the natural spelling.

Description & Review Guide

  • What are the major changes? the timeout validation accepts int (coerced to float) alongside float and httpx.Timeout.
  • What is the impact of these changes? int timeouts work; nothing else changes.
  • What do you want reviewers to focus on? the guard change in the a2a agent construction path.

Related Issue

Fixes #8515

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR is linked to an issue and there is no other open PR for this issue
  • This is not a breaking change.

@ManoharPaturi
Python: accept integer timeouts in A2AAgent
1110a7f 
A2AAgent._create_timeout_config only accepted float and httpx.Timeout, so
A2AAgent(url=..., timeout=30) raised TypeError. Per PEP 484's numeric tower
an int is a valid float, and httpx.Timeout itself accepts ints. Accept int
(and float) while continuing to reject bool and other types.
Copilot AI balanced review requested due to automatic review settings September 18, 2026 12:28
Copilot AI reviewed Sep 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@agent-framework-automation agent-framework-automation Bot added the python Usage: [Issues, PRs], Target: Python label Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@eavanvalkenburg Eduard van Valkenburg (eavanvalkenburg) Awaiting requested review from eavanvalkenburg eavanvalkenburg is a code owner
@SergeyMenshykh SergeyMenshykh Awaiting requested review from SergeyMenshykh SergeyMenshykh is a code owner
@rogerbarreto Roger Barreto (rogerbarreto) Awaiting requested review from rogerbarreto rogerbarreto is a code owner
@westey-m westey (westey-m) Awaiting requested review from westey-m westey-m is a code owner
@moonbox3 Evan Mattson (moonbox3) Awaiting requested review from moonbox3 moonbox3 is a code owner
@jpalvarezl Jose Alvarez (jpalvarezl) Awaiting requested review from jpalvarezl jpalvarezl is a code owner
@TaoChenOSU Tao Chen (TaoChenOSU) Awaiting requested review from TaoChenOSU TaoChenOSU is a code owner
@giles17 Giles Odigwe (giles17) Awaiting requested review from giles17 giles17 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

python Usage: [Issues, PRs], Target: Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Python: A2AAgent rejects int timeouts (only float/httpx.Timeout accepted)

2 participants

@ManoharPaturi