Python: break get_latest timestamp ties with the checkpoint lineage chain - #8514
Open
Manohar Paturi (ManoharPaturi) wants to merge 6 commits into
Open
Manohar Paturi (ManoharPaturi) wants to merge 6 commits into
Manohar Paturi (ManoharPaturi) wants to merge 6 commits into
Conversation
…ming and post-stream parsing Define is_pydantic_response_format once and reuse it to drive both skip_text and post-stream structured output recovery, preventing the two paths from drifting.
…hain Identical timestamps at a superstep boundary made max() pick whichever checkpoint the storage iterated first, so get_latest could return a stale checkpoint depending on save order. Both storages now first drop every checkpoint that another one supersedes via previous_checkpoint_id and only then compare timestamps. Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
Manohar Paturi (ManoharPaturi)
requested review from
SergeyMenshykh,
Tao Chen (TaoChenOSU),
Vincent Biret (baywet),
Eduard van Valkenburg (eavanvalkenburg),
Giles Odigwe (giles17),
Jose Alvarez (jpalvarezl),
Evan Mattson (moonbox3),
Peter Ibekwe (peibekwe),
Roger Barreto (rogerbarreto) and
westey (westey-m)
as code owners
September 18, 2026 11:59
Manohar Paturi (ManoharPaturi)
deployed
to
github-app-auth
September 18, 2026 11:59 — with
GitHub Actions
Active
Manohar Paturi (ManoharPaturi)
deployed
to
github-app-auth
September 18, 2026 11:59 — with
GitHub Actions
Active
Manohar Paturi (ManoharPaturi)
deployed
to
github-app-auth
September 18, 2026 12:00 — with
GitHub Actions
Active
Manohar Paturi (ManoharPaturi)
deployed
to
github-app-auth
September 18, 2026 12:00 — with
GitHub Actions
Active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8513.
Both
get_latestimplementations first drop every checkpoint that another one supersedes viaprevious_checkpoint_id(the ordering theWorkflowCheckpointdocstring already defines), then compare timestamps among the remaining tips. Unrelated chains and storages without lineage metadata fall back to the previous behavior.Regression test saves a parent/child pair with identical timestamps in both orders and asserts the child always wins; it fails on main. Checkpoint suite green.