Python: Move approval storage to platform supplied durable dir - #7495
Closed
TaoChenOSU wants to merge 2 commits into
Closed
Python: Move approval storage to platform supplied durable dir#7495TaoChenOSU wants to merge 2 commits into
TaoChenOSU wants to merge 2 commits into
Conversation
TaoChenOSU
temporarily deployed
to
github-app-auth
August 3, 2026 22:33 — with
GitHub Actions
Inactive
TaoChenOSU
temporarily deployed
to
github-app-auth
August 3, 2026 22:33 — with
GitHub Actions
Inactive
TaoChenOSU
temporarily deployed
to
github-app-auth
August 3, 2026 22:33 — with
GitHub Actions
Inactive
TaoChenOSU
temporarily deployed
to
github-app-auth
August 3, 2026 22:34 — with
GitHub Actions
Inactive
TaoChenOSU
temporarily deployed
to
github-app-auth
August 3, 2026 22:34 — with
GitHub Actions
Inactive
TaoChenOSU
temporarily deployed
to
github-app-auth
August 3, 2026 22:34 — with
GitHub Actions
Inactive
TaoChenOSU
temporarily deployed
to
github-app-auth
August 3, 2026 22:34 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Python Foundry Hosting ResponsesHostServer to root its file-backed storage (sessions, workflow checkpoints, and function approval requests) under the platform-provided durable home directory when running in hosted mode, aligning approval storage behavior with the earlier checkpoint fix.
Changes:
- Added
_resolve_storage_path(...)helper to resolve hosted storage paths under$HOME(with/home/sessionfallback) and local paths under the current working directory. - Updated
ResponsesHostServerto use the resolved paths for checkpoint storage, session store, and file-based function approval storage (including per-user approval storage paths). - Expanded unit tests to validate hosted vs local path derivation and fallback behavior when
HOMEis unusable.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| python/packages/foundry_hosting/agent_framework_foundry_hosting/_responses.py | Introduces shared hosted/local storage path resolution and applies it to sessions, checkpoints, and approval storage. |
| python/packages/foundry_hosting/tests/test_responses.py | Updates/extends tests to validate the new hosted storage rooting and fallbacks for sessions and approvals. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
TaoChenOSU
temporarily deployed
to
github-app-auth
August 3, 2026 22:52 — with
GitHub Actions
Inactive
Contributor
|
@TaoChenOSU is the PR title accurate? |
TaoChenOSU
temporarily deployed
to
github-app-auth
August 4, 2026 17:11 — with
GitHub Actions
Inactive
Contributor
Author
No, closing this PR because we are moving to a Foundry supplied solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
Addresses #7414
Follow up to #7220
Description & Review Guide
Related Issue
Fixes #7414
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.