Python: Update ollama samples#6412
Open
alxxdev wants to merge 2 commits into
Open
Conversation
## Summary
Fix `ollama_chat_client.py` sample where `tools` was passed as a direct keyword argument to `OllamaChatClient.get_response()`, causing `TypeError`.
## Problem
`FunctionInvocationLayer.get_response()` does not accept `tools` as a parameter. It should be passed inside the `options` TypedDict (`ChatOptions`). Running the sample raised:
```
TypeError: FunctionInvocationLayer.get_response() got an unexpected keyword argument 'tools'
```
## Fix
Replaced:
```python
client.get_response(messages, tools=get_time)
client.get_response(messages, tools=get_time, stream=True)
```
With:
```python
client.get_response(messages, options={"tools": get_time})
client.get_response(messages, options={"tools": get_time}, stream=True)
```
## Related issue
Closes microsoft#6411
## Testing
- Manual: sample now runs without TypeError
- Verified tool calling works with `llama3.2` model and Ollama
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Ollama chat client sample to pass tool configuration via an options dictionary instead of the tools keyword argument.
Changes:
- Switched streaming call to
client.get_response(..., options={"tools": get_time}, stream=True) - Switched non-streaming call to
client.get_response(..., options={"tools": get_time})
github-actions
Bot
changed the title
eavanvalkenburg
approved these changes
Jun 10, 2026
eavanvalkenburg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
ollama_chat_client.pysample wheretoolswas passed as a direct keyword argument toOllamaChatClient.get_response(), causingTypeError.Problem
FunctionInvocationLayer.get_response()does not accepttoolsas a parameter. It should be passed inside theoptionsTypedDict (ChatOptions). Running the sample raised:Fix
Replaced:
With:
Related issue
Closes #6411
Testing
llama3.2model and OllamaMotivation and Context
Description
Contribution Checklist