Python: apply function_invocation_configuration in BaseChatClient.as_agent#5198
Draft
Bortlesboat wants to merge 1 commit intomicrosoft:mainfrom
Draft
Python: apply function_invocation_configuration in BaseChatClient.as_agent#5198Bortlesboat wants to merge 1 commit intomicrosoft:mainfrom
Bortlesboat wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Member
|
just added a note on the original issue, that this is not the way to fix that issue, if you are up for it, you can change this PR, open a new PR or we can pick it up with the team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #5180.
BaseChatClient.as_agent()currently acceptsfunction_invocation_configurationbut forwards it intoAgent(**agent_kwargs), whereAgent.__init__()does not accept that keyword. In practice this raises aTypeErrorinstead of applying the configuration to function-invoking clients.Description
This change keeps the override on the client side, which is where
FunctionInvocationLayerconsumes it:function_invocation_configurationintoAgent()FunctionInvocationLayer, normalize and apply the override directly toself.function_invocation_configurationas_agent(function_invocation_configuration=...)so the issue stays fixedContribution Checklist