Add AzureLinux official WSL image to the distribution manifest#41120
Add AzureLinux official WSL image to the distribution manifest#41120mfrw wants to merge 4 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This PR updates the WSL distribution manifest to add AzureLinux as a modern distribution option, including architecture-specific download locations and SHA256 hashes.
Changes:
- Added a new
ModernDistributions.AzureLinuxentry with anAzureLinux-4.0-BETAimage. - Provided amd64/arm64
.wsldownload URLs and corresponding SHA256 hashes.
| "Url": "https://osrelease.download.prss.microsoft.com/pr/download/AzureLinux-4.0-x86_64.wsl", | ||
| "Sha256": "92e709a8f7e9e5981d839c74358449857dcdfae57636a6b5e30001898790d992" | ||
| }, | ||
| "Arm64Url": { | ||
| "Url": "https://osrelease.download.prss.microsoft.com/pr/download/AzureLinux-4.0-aarch64.wsl", | ||
| "Sha256": "6ac4a5cdfa8d3c1308cb6cca133c0f30a47ae2cb639ee4cde0ada2d3a65298ce" |
|
@mfrw - there are some issues that should be resolved before merging, can you please take a look? |
Sure - will do |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
distributions/DistributionInfo.json:263
- The download URLs point to
osrelease.download.prss.microsoft.com/pr/download/..., which appears to be a PR-specific or internal distribution endpoint (and is the onlyprss.microsoft.comreference in this manifest). For an official distro entry, this should likely use a stable, long-lived public URL (similar to the other ModernDistributions entries) to avoid future breakage if PR artifacts are rotated/removed.
"Url": "https://osrelease.download.prss.microsoft.com/pr/download/AzureLinux-4.0-x86_64.wsl",
"Sha256": "92e709a8f7e9e5981d839c74358449857dcdfae57636a6b5e30001898790d992"
},
"Arm64Url": {
"Url": "https://osrelease.download.prss.microsoft.com/pr/download/AzureLinux-4.0-aarch64.wsl",
"Sha256": "6ac4a5cdfa8d3c1308cb6cca133c0f30a47ae2cb639ee4cde0ada2d3a65298ce"
| "Name": "AzureLinux-4.0-BETA", | ||
| "FriendlyName": "Azure Linux 4.0 (BETA)", | ||
| "Default": true, |
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
PR Raised to address the missing icon file: |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
distributions/DistributionInfo.json:256
- The PR title says this adds an "official" Azure Linux WSL image, but the manifest entry is explicitly marked as BETA (Name ends with "-BETA" and FriendlyName includes "(BETA)"). This is a user-visible mismatch: either the entry should be the stable/official image (no BETA labeling), or the PR title/intent should be updated to reflect that this is a beta image.
"Name": "AzureLinux-4.0-BETA",
"FriendlyName": "Azure Linux 4.0 (BETA)",
"Default": true,
|
@mfrw What happens when this package comes out of BETA? It will be seen as an entirely new WSL distribution, which really isn't the case. I'd recommend using a name like |
craigloewen-msft
left a comment
There was a problem hiding this comment.
Should resolve naming first.
OneBlue
left a comment
There was a problem hiding this comment.
Thank you for doing this !
Looking through the tar, there are a couple things that we should fix before merging:
- The icon referenced by
/etc/wsl-distribution.confdoesn't exist:
[shortcut]
enabled = true
icon = /usr/share/pixmaps/fedora-logo.ico # <= Not in the tar
-
The OOBE script references Fedora (I'm guessing because it's inspired from their OOBE script)
-
The manifest name doesn't match the distribution name in
/etc/wsl-distribution.conf(AzureLinux-4 vs AzureLinux-4.0-BETA) -
Some redundant system units are enabled by default.
Specifically:
systemd-vconsole-setup.service(WSL automatically configures a TTY on that device, and this will typically fail if multiple distros try to do this in parallel)systemd-resolved.service(WSL owns the DNS and writes to/etc/resolv.conf)systemd-networkd-*(WSL configures networking, distributions shouldn't need to make changes to adapter configuration)getty@tty1.serviceThis tty is essentially unreachable so I'd recommend not running it at all. This will also fail if another distro tries to do this as well
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
distributions/DistributionInfo.json:263
- The AzureLinux ModernDistributions URLs point at a
.../pr/download/...endpoint, which looks like a pull-request/staging artifact location and may not be stable long-term. If this URL disappears or is rotated,wsl --install/ distro list fetching will break for this entry. Please switch these to a long-lived, versioned release location intended for public consumption (similar to the other distro entries).
"Url": "https://osrelease.download.prss.microsoft.com/pr/download/AzureLinux-4.0-x86_64.wsl",
"Sha256": "a7b3f2ff714105dcb22a45c9b8072b66df7a71b0b6dcd97455b1fb60ca176056"
},
"Arm64Url": {
"Url": "https://osrelease.download.prss.microsoft.com/pr/download/AzureLinux-4.0-aarch64.wsl",
"Sha256": "f5a36b4185977cef3d62db44acb566da039d81db3bae04f6241364189a754d6c"
|
Ack @craigloewen-msft & @OneBlue - will address the feedback |
|
@craigloewen-msft my reasoning for asking @mfrw to explicitly name the image as a Beta is because there won't be an easy way to update to the GA release once we launch. The alternative would be to hold the image back until we GA officially. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
distributions/DistributionInfo.json:263
- The AzureLinux ModernDistributions URLs point at
osrelease.download.prss.microsoft.com/pr/download/.... The/pr/path suggests this may be a preview/ephemeral artifact location; if it gets garbage-collected,wsl --install --from-file/ modern distro install flows could break. Prefer a stable, publicly supported release URL (or an aka.ms redirect) intended for long-term consumption, and keep this manifest pointing at that stable endpoint.
"Amd64Url": {
"Url": "https://osrelease.download.prss.microsoft.com/pr/download/AzureLinux-4.0-x86_64.wsl",
"Sha256": "a7b3f2ff714105dcb22a45c9b8072b66df7a71b0b6dcd97455b1fb60ca176056"
},
"Arm64Url": {
"Url": "https://osrelease.download.prss.microsoft.com/pr/download/AzureLinux-4.0-aarch64.wsl",
"Sha256": "f5a36b4185977cef3d62db44acb566da039d81db3bae04f6241364189a754d6c"
distributions/DistributionInfo.json:256
- The PR title says this adds an "official" AzureLinux WSL image, but the entry’s FriendlyName is labeled "(BETA)". This is a user-visible string and reads like a prerelease; please align either the PR description/title or the manifest entry so they communicate the same status (official release vs beta/preview).
"Name": "AzureLinux-4.0",
"FriendlyName": "Azure Linux 4.0 (BETA)",
"Default": true,
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
benhillis
left a comment
There was a problem hiding this comment.
You've changed all the line endings on this file. Please don't do that.
Signed-off-by: Muhammad Falak R Wani falakreyaz@gmail.com
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed