fixed title error visibility

[shuaiyuanxx]

Summary of the Pull Request

The Start menu launches the MSIX wsl.exe, which forwards the command to the installed MSI wsl.exe. The inner process prints the actual error, but only the outer MSIX process retains the App activation context and owns the console window. Previously, the outer process returned immediately when the inner process failed.

The outer process now detects an App-activated launch and prompts before exiting when the inner process returns WSL's client failure code (-1). Linux command exit codes are not affected.

PR Checklist

• Closes: Closes Freshly installed on a brand new Windows 11, just opens and closes, doesn't even let me see an error message #41112
• Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• Tests: Added/updated if needed and all pass
• Localization: All end user facing strings can be localized
• Dev docs: Added/updated if needed
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

The MSIX wsl.exe owns the Start menu console, while the forwarded MSI wsl.exe prints the actual startup error. This change keeps the outer process open when the inner process returns WSL's client failure code (-1), without affecting Linux exit codes or terminal launches.

Validation Steps Performed

• Clean-built wsl.exe and the signed glue MSIX.
• Triggered a deterministic startup failure through the real Start menu entry.
• Verified the official build closed immediately, while the patched build kept the error window open.
• Verified normal terminal invocations and exit codes were unchanged.

[Copilot]

Pull request overview

This PR improves error visibility when launching WSL from the Start menu (MSIX wsl.exe forwarding to the installed MSI wsl.exe). When the inner MSI process fails with WSL’s client failure exit code (-1), the outer MSIX process now keeps the console window open (for App-activated launches) by enabling the existing “prompt before exit” behavior.

Changes:

• Detect App-activated launches in the MSIX wrapper path (AppInstance::GetActivatedEventArgs() != nullptr).
• After forwarding to the MSI package, set g_promptBeforeExit = true when the forwarded process returns -1 (WSL client failure), so the Start menu console doesn’t close immediately.

[OneBlue]

I think this is a good change, although if we happen to run a command line like wsl --install --prompt-before-exit in that context, we would follow that command line to the inner process, and therefore end up with two prompts.

I don't think that's a huge deal though, and probably not worth the additional complexity to try to parse the command line at that stage