Fix missing assignment and incorrect context in hcs.cpp debug logging#13973
Merged
Conversation
…ontext Co-authored-by: benhillis <17727402+benhillis@users.noreply.github.com>
Co-authored-by: benhillis <17727402+benhillis@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve logging of HCS helper utilities on debug builds
Fix missing assignment and incorrect context in hcs.cpp debug logging
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fixes two bugs introduced in the HCS debug logging PR:
GetSchemaVersion()computed but never stored the schema version, always returning {0, 0}RevokeVmAccess()used wrong execution context (HNS instead of HCS)PR Checklist
Detailed Description of the Pull Request / Additional comments
Changes
majorVersionandminorVersionto staticg_schemaVersionvariable after calculation loopExecutionContextfromContext::HNStoContext::HCSto match the HCS API being called (HcsRevokeVmAccess)Both issues were logic errors - computed values not stored and incorrect context type for the API category.
Validation Steps Performed
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.