Conversation
deep1712
force-pushed
the
users/devaid/RefactoringNetworkingWorkload
branch
2 times, most recently
from
February 21, 2026 17:31
19a1f76 to
3b2346f
Compare
deep1712
force-pushed
the
users/devaid/RefactoringNetworkingWorkload
branch
from
March 24, 2026 13:05
c849c61 to
bbc8a84
Compare
|
Review comment - The refactored command-line generation is not reached consistently. CPSExecutor.GetCommandLineArguments() still returns null, and LatteExecutor.GetCommandLineArguments() returns an empty string. NTttcp and SockPerf server are created through the component-copy constructors in CreateWorkloadExecutor(), but those constructors do not initialize the new CommandLine* properties. Consequently, several production paths will launch workloads with null or empty arguments. Command construction should occur inside GetCommandLineArguments() after InitializeAsync, not selectively inside constructors. Please also add tests asserting the exact generated command for every tool, role, and platform. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.