fix: avoid host-only eval crash when app_agent_log is empty#306
Open
grtninja wants to merge 1 commit intomicrosoft:pre-releasefrom
Open
fix: avoid host-only eval crash when app_agent_log is empty#306grtninja wants to merge 1 commit intomicrosoft:pre-releasefrom
grtninja wants to merge 1 commit intomicrosoft:pre-releasefrom
Conversation
Author
|
@microsoft-github-policy-service agree I've been a Windows Insider since January 30, 2015, and a long-time Windows feedback participant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app_agent_log=[]no longer crashesuser_content_construction_head_tail()Why
Fixes #304. Host-only tasks can complete without any AppAgent steps, so indexing
trajectory.app_agent_log[0]is unsafe and can terminate evaluation withIndexError.Validation
python -m pytest -q tests\\unit\\test_eva_prompter_host_only.pyRisk Notes