Skip to content

Cache exports lookups and path patterns in module specifier generation - #64724

Draft
Gavin Kline (gwkline) wants to merge 3 commits into
microsoft:mainfrom
gwkline:perf/exports-specifier-cache
Draft

Gavin Kline (gwkline) wants to merge 3 commits into
microsoft:mainfrom
gwkline:perf/exports-specifier-cache

Conversation

@gwkline

Copy link
Copy Markdown

Fixes #64721

Analysis

When declaration emit (or auto-import) needs a specifier for a file, it searches the mapping tables that could name it:

  • exports. For a file in a package with an "exports" map, tryGetModuleNameFromExports walks every entry and condition, resolving a path and comparing it with the target for each. For every string entry it also recomputes the target's JS file name (and, for "imports", its output and declaration file names through outputpaths). It also joins the package name with every subpath before knowing whether the entry matches.
  • paths. With "paths" (or a package's "typesVersions"), tryGetModuleNameFromPaths resolves every pattern against the table's base directory. For every pattern it also recomputes the candidate specifiers of the target file, although they don't depend on the pattern and processEnding can query the file system.

The nodebuilder caches the final specifier per importing file, so both scans repeat for every file that names the same target. The cost is importing files × table size. Emit holds a file's checker exclusively, so this sits on the emit critical path.

Fix

  • Exports cache. ModuleSpecifierGenerationHost gains ModuleSpecifierGenerationCache(), returning a modulespecifiers.GenerationCache or nil. The compiler's Program owns one, which its emit host forwards to, and the auto-import alias resolver owns another. The cache memoizes the subpath an exports map publishes a target under. The key is the parsed *packagejson.PackageJson, the package directory and name, the target file, the resolution mode, and the compiler options. A re-read package.json therefore never serves a stale answer, and neither does a different option set. Negative results are cached too.
  • Paths cache. The same cache keeps the resolved patterns of each paths / typesVersions table, keyed by the table and its base directory. A lookup becomes prefix and suffix compares against precomputed strings.
  • Per-lookup work. The candidate specifiers in tryGetModuleNameFromPaths are computed once per lookup. exports/imports lookups compute the target's file names once per lookup, and build an entry's specifier only when that entry matches.
  • typesVersions tables. GetVersionPaths returns VersionPaths by value, and GetPaths built the table lazily on the receiver. Every caller therefore rebuilt the table on its own copy, including module resolution on every resolution through such a package, and the table had no stable identity to cache by. The table is now built once, inside the sync.Once that selects the version paths. TestGetVersionPathsSharesTable pins this.

Results are unchanged: lookups return the same specifiers in the same table order, and emitted declarations are byte-identical on every project below. Reachability of node_modules is still checked outside the cached lookup, so this composes with #64599.

New tests in modulespecifiers/cache_test.go and packagejson/packagejson_test.go:

  • They check cached against uncached results across conditions, custom conditions, resolution modes, patterns, entries with extensions, and absolute patterns resolved from different base directories.
  • Every case runs twice against one cache, so a key that dropped any input fails. The custom-conditions case caught exactly that in an earlier version of this patch.
  • Benchmarks cover both scans.
Benchmark Time per lookup Allocations per lookup
exports scan, 180 subpaths, uncached 371 µs → 298 µs 1,984 → 1,085
paths scan, 400 patterns, uncached 331 µs → 240 µs 7,201 → 6,004
paths scan, 400 patterns, cached 331 µs → 6.4 µs 7,201 → 3
Project Emit time Allocations
exports generator from the issue 0.188 s → 0.077 s 2.82M → 0.95M
paths generator from the issue 0.64 s → 0.096 s 25.2M → 1.24M
private monorepo package, declaration build (11k files) 2.48 s → 1.45 s (total 7.39 s → 6.47 s) 56.6M → 51.2M

The profiling, the patch and this description were produced with Claude Code (Claude Fable 5.1 and Claude Opus 5.5). I have read and understand the change and will handle review myself.

Copilot Checklist

I successfully ran the applicable command at the end of my session, and it completed without error:

  • npx hereby validate
  • npx hereby validate --api (for TypeScript API changes; no API changes here)

🤖 Generated with Claude Code

Gavin Kline (gwkline) and others added 3 commits October 9, 2026 20:29
Generating a module specifier for a file inside a package with an
"exports" map scans every entry of the map, resolving and comparing a
candidate path for each, until the subpath that publishes the target file
is found. The nodebuilder caches the final specifier per importing file,
so declaration emit repeated the scan for every file that referenced the
same target: on a build with many declaration files and dependencies with
large exports maps it was most of the time spent on module specifiers and
about eight percent of all allocations.

The answer depends only on the parsed package.json, the package directory
and name, the target file and the resolution mode, so hosts now keep a
memo of it keyed by exactly those inputs. The compiler's Program owns one
and its emit host forwards to it; the auto-import alias resolver owns
one; hosts may return nil to opt out. Keying by the parsed package.json
means a re-read file never serves a stale answer.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…kups

Lookups through a tsconfig "paths" (or package "typesVersions") table
resolved every pattern against the table's base directory and recomputed
the candidate specifiers for the target file once per pattern, although
neither depends on the other. With a table of a few hundred entries, as in
workspaces that map every library, this dominated declaration emit.

- The resolved patterns of a table are now computed once per host and
  kept in the module specifier generation cache, keyed by the table and
  its base directory. The cache, previously only for package.json
  "exports" lookups, is renamed GenerationCache accordingly.
- The candidate specifiers are computed once per lookup.
- "exports" and "imports" lookups compute the target's emitted file
  names once per lookup instead of once per entry, and build an entry's
  specifier only when the entry matches.
- "exports" lookups are also keyed by the compiler options, so a host
  serving several option sets never returns another set's answer; a new
  test with custom conditions failed without this.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GetVersionPaths returns VersionPaths by value and GetPaths builds the
paths table lazily on the receiver, so every caller built a table of its
own on its copy: module resolution through a package with typesVersions
rebuilt it on every resolution, and module specifier generation, which
now caches resolved patterns by table identity, would never have found a
cached entry and would have kept adding new ones. Build the table once
when the version paths are selected so that every copy shares it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@typescript-automation typescript-automation Bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 10, 2026
@microsoft-github-policy-service

Copy link
Copy Markdown

Gavin Kline (@gwkline) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Module specifier generation rescans package.json exports and tsconfig paths for every importing file

1 participant