Skip to content

Merge export * tables without per-name collision trackers - #64722

Draft
Gavin Kline (gwkline) wants to merge 2 commits into
microsoft:mainfrom
gwkline:perf/export-star-tables
Draft

Gavin Kline (gwkline) wants to merge 2 commits into
microsoft:mainfrom
gwkline:perf/export-star-tables

Conversation

@gwkline

Copy link
Copy Markdown

Fixes #64719

Analysis

getExportsOfModuleWorker resolves a module's exports by cloning its own table. For each export * declaration it merges the re-exported module's table into a scratch table, then merges the scratch table into the result. To report TS2308 ("Module ... has already exported a member named ...") it allocates an ExportCollision struct, holding the module specifier text, for every name contributed by every export *. Afterwards it iterates that per-name table again to find the entries that actually collided. Every visited module is cloned as well, and every visited module's export names are copied into a set that is only consulted when an export type * was seen.

So each export * layer costs several allocations per re-exported name. That holds even for a module with a single export *, where nothing can collide. Barrels over large modules (generated clients, or date-fns- and AWS-SDK-style entry points) pay this on every layer. The generator in the issue spends nearly all of its 0.23 s check here.

Fix

  • Each re-exported table is merged straight into the module's result table, which is pre-sized to the sum of the tables being merged.
  • Only the first contributing export * per name is recorded, and only when the module has more than one export *. Names that do collide go into a map that is almost always empty. The specifier text is computed only when a diagnostic is reported.
  • Modules without export * are no longer cloned when visited from an importer. The clone is kept for the module whose table is cached, since getExportsOfModule may extend it.
  • Instead of copying every visited module's names into a set, the worker records the modules reached through a non-type-only path. It applies them to typeOnlyExportStarMap only when that map exists.

Semantics are unchanged. The first contributing declaration still wins, and a module's own exports still shadow re-exports without an error. default and export= are handled as before, and so are the export type * override rules. extendExportSymbols and ExportCollisionTable had no other users and are removed.

New test exportStarNameCollisions covers each case the merge distinguishes: collisions from two and three declarations, the same symbol reached twice, a local export silencing a collision, a single export *, export type * on either side, and a chain of re-exporting modules. Its baselines were generated with the old code and are unchanged. No existing baseline changes.

Results on an M3 Pro, with medians of alternating runs:

Program Check time Allocations
generator from the issue (207 files) 0.234 s → 0.052 s 1.58M → 0.24M
private monorepo app (9.6k files) 2.98 s → 2.84 s (−4.7%) 30.3M → 28.9M
private monorepo package (8.6k files) 4.10 s → 3.95 s (−3.6%) 46.1M → 44.7M

The profiling, the patch and this description were produced with Claude Code (Claude Fable 5.1 and Claude Opus 5.5). I have read and understand the change and will handle review myself.

Copilot Checklist

I successfully ran the applicable command at the end of my session, and it completed without error:

  • npx hereby validate
  • npx hereby validate --api (for TypeScript API changes; no API changes here)

🤖 Generated with Claude Code

Gavin Kline (gwkline) and others added 2 commits October 9, 2026 17:34
getExportsOfModuleWorker allocated an ExportCollision struct for every name
contributed by every export * declaration, kept the names in a separate
table before merging them, and then iterated that table once more to look
for duplicates. For modules that re-export large modules this dominated the
allocations of module export resolution.

The merge now writes straight into the module's table, records only the
first contributing declaration per name and only when a module has more
than one export * declaration, and keeps the names that collided in a map
that is usually empty. Modules without export * declarations no longer have
their tables cloned when visited from an importer, and the names used to
undo type-only marking are collected only when an 'export type *' was seen.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Covers the cases the export * merge distinguishes: colliding names from
two and three declarations, the same symbol reached twice, a module's own
export silencing the collision, a single export *, export type * on either
side, and a chain of re-exporting modules. Baselines were generated before
the merge was rewritten and are unchanged by it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@typescript-automation typescript-automation Bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 10, 2026
@microsoft-github-policy-service

Copy link
Copy Markdown

Gavin Kline (@gwkline) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

export * resolution allocates per re-exported name, slowing checks of barrels over large modules

1 participant