Make bundled/lib the canonical lib file source - #63993
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Makes tsc/internal/bundled/libs the canonical source for TypeScript’s bundled declaration files.
Changes:
- Removes the intermediate
sourcegeneration pipeline. - Derives embedded lib metadata directly from canonical files.
- Adds header and line-ending validation.
Reviewed changes
Copilot reviewed 3 out of 113 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tsc/internal/bundled/generate.go |
Reads, validates, and embeds canonical libs. |
tsc/internal/bundled/README.md |
Documents the new layout. |
tsc/internal/bundled/CopyrightNotice.txt |
Relocates the shared header. |
tsc/internal/bundled/libs/*.d.ts |
Adds 108 canonical library sources. |
tsc/internal/bundled/source/libs.json |
Removes obsolete generation metadata. |
tsc/internal/bundled/source/CopyrightNotice.txt |
Removes the former header source. |
tsc/internal/bundled/source/*.d.ts |
Removes obsolete intermediate declarations. |
Files not reviewed (1)
- tsc/internal/bundled/generate.go: Generated file
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Wesley Wigham (weswigham)
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no reason to generate these files anymore, it's easier to just have them be their own sources and include them, then check that they're formatted right.
Unfortunately, this means no
.generated.d.tsin the filename, I feel like that's fine. I'll update the flow that checks the modified files separately, or not at all.That and DOM lib generator's migration script needs to do a rename now.