Redo localization for onboarding - #63987
Draft
Jake Bailey (jakebailey) wants to merge 4 commits into
Draft
Conversation
Remove the separate extra diagnostics catalog and allocate native-only messages within the standard compiler and language service ranges. Reject duplicate diagnostic codes during generation.
Document the intentional native filesystem operations used to load locale files beside the executable and use errors.New for the static error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reorganizes our localization files to match what the loc team expects, which should allow us to start localization up again.
The downside is that the loc team isn't going to be running any sort of post-processing steps, I don't think, which means the
.json.gzconcept has to go away. This sucks for binary sizes, so, at the same time, reintroduce thelocdir for the output files that we read at startup. Non-noembedusers unfortunately have to deal with the full.jsonfiles, which sadly increases binary size by some 3.4MB. I'll have to look into some way that we could still do that. I do not want to introduce any sort of build-time dependence into these files, as that would not bego get-able, and so it'd be better to simply have a build tag that omits the loc entirely for those who do not want it.