fix: add -p flag to mkdir to prevent build error on Unix systems#3411
Open
sw1tch3roo wants to merge 1 commit intomicrosoft:v2from
Open
fix: add -p flag to mkdir to prevent build error on Unix systems#3411sw1tch3roo wants to merge 1 commit intomicrosoft:v2from
sw1tch3roo wants to merge 1 commit intomicrosoft:v2from
Conversation
Member
|
I exclusively develop this repo on Linux and have never hit this; when would the directory not exist? |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const outDir = join(__dirname, "..", "..", "typescriptlang-org", "static", "js", "examples"); | ||
|
|
||
| if (!existsSync(outDir)) execSync(`mkdir ${outDir}`); | ||
| if (!existsSync(outDir)) execSync(`mkdir -p ${outDir}`); |
Check warning
Code scanning / CodeQL
Shell command built from environment values Medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a build issue on Unix-like systems (e.g., macOS, Linux) where the command mkdir in packages/playground-examples/scripts/copyFiles.js fails because the parent directories may not exist.
Added a check to ensure the target directory exists before calling mkdir.
Replaced mkdir with mkdir -p to avoid errors when the directory tree doesn't exist.
Tested locally: the build now completes successfully on macOS.
Thank you for reviewing this fix!
P.S. This issue doesn't occur on Windows because mkdir there behaves like mkdir -p by default, but it fails on Unix-based systems without the -p flag.