Fix Python schema conversion for variadic tuples with union elements - #437
Open
林SO (Linxiushen) wants to merge 1 commit into
Open
林SO (Linxiushen) wants to merge 1 commit into
林SO (Linxiushen) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python schema converter raises
AssertionErrorfor variadic tuples whose elements are unions, such astuple[int | str, ...],tuple[str | None, ...], ortuple[Literal["yes", "no"], ...]. This also prevents constructing aTypeChatJsonTranslatorfor a dataclass containing these fields.Render these element types as
Array<...>, matching the existing handling of lists with union elements. Extend the tuple schema snapshot with union, nullable, literal, and nested cases, and add a translator regression that validates a fixed JSON response into the expected Python tuples.Validation on Python 3.12:
git diff --checkpasses.The translator test uses the existing fixed-response model; no live provider calls were made.