Address PR #238 review-thread feedback in drawing example and interactive input helper#337
Closed
Copilot wants to merge 2 commits into
Closed
Address PR #238 review-thread feedback in drawing example and interactive input helper#337Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix code based on review comments
Address PR #238 review-thread feedback in drawing example and interactive input helper
Jun 1, 2026
Contributor
|
I made these changes in @gvanrossum 's fork and so they're now in #238 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies all requested updates from the linked review thread on PR #238, with no unrelated scope expansion. It tightens drawing schema validity, aligns discriminant conventions, and removes two renderer/interactive edge-case failure points.
Schema tightening + consistency
Style.line_styletoLiteral["solid", "dashed", "dotted"]instead of free-formstr.UnknownText.typetoLiteral["Unknown"].Arrowdocstring to match implemented behavior (arrow head at end).Renderer hardening
line_styleis unexpected.Lint-safe optional readline import
readlineimport as intentionally unused to avoidF401noise while preserving side-effect behavior.