Skip to content

Recover translation-bench checkpoints after interrupted writes - #2769

Merged
Dominic Nguyen (datduyng) merged 12 commits into
mainfrom
domnguyen/list-determiner-listname
Aug 21, 2026
Merged

Recover translation-bench checkpoints after interrupted writes#2769
Dominic Nguyen (datduyng) merged 12 commits into
mainfrom
domnguyen/list-determiner-listname

Conversation

@datduyng

@datduyng Dominic Nguyen (datduyng) commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Makes single-writer translation-bench checkpoints recover from interrupted JSONL writes while preserving validated resume and merge behavior.

Before: header\n{"caseId":"1"}\n{"caseId":
Append: {"caseId":"2"}
After:  header\n{"caseId":"1"}\n{"caseId":"2"}
Test:   PASS translationBench.checkpointPrimitives.spec.js (1 passed, 0 failed)

Treat determiner-only listName captures (the/my/list) as invalid via
checked_wildcard validation so "add ham to the list" falls through to
the LLM instead of creating a list named "the".
- Normalize: strip true determiners + trailing list(s) only (keep
  whole foods / active tasks / most wanted intact)
- Reject bare closed-class, of-led junk, closed-class "… of them",
  lots/rest partial anaphora; accept open-class "photos of them"
- Execute guards on all listName actions; removeItems throws if missing
- Salvage key __recovered__; checked_wildcard on createList
- Expand unit coverage for validator, coalesce, and edge names
@datduyng Dominic Nguyen (datduyng) changed the title Reject placeholder list names from list grammar matches Recover translation-bench checkpoints after interrupted writes Aug 21, 2026
Comment thread ts/packages/benchmarks/src/translationBench/synthesizer/generationSupport.ts Outdated
@datduyng
Dominic Nguyen (datduyng) marked this pull request as ready for review August 21, 2026 18:41
@datduyng
Dominic Nguyen (datduyng) added this pull request to the merge queue Aug 21, 2026
Merged via the queue into main with commit ae9c10c Aug 21, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants