Improve getKeys script to ignore comments and trim keys#2120
Merged
GeorgeNgMsft merged 4 commits intomainfrom Apr 2, 2026
Merged
Improve getKeys script to ignore comments and trim keys#2120GeorgeNgMsft merged 4 commits intomainfrom
GeorgeNgMsft merged 4 commits intomainfrom
Conversation
Contributor
Author
@microsoft-github-policy-service agree company="Microsoft" |
TalZaccai
approved these changes
Apr 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the getKeys developer script’s .env parsing to avoid treating comment/blank lines as key/value entries, improving compatibility with .env files that include separators like #-------------------.
Changes:
- Filter out empty lines and full-line
#comments when reading.envinreadDotenv(). - Keep the existing key/value splitting logic for non-comment lines.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
….com/microsoft/TypeAgent into dev/georgeng/getkeys_ignore_comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a filter to ignore comments when running getKeys.readDotenv and handle scenarios such as using "#-------------------" for a page break.
For example :

Also added some minor k/v trimming + CRLF handling