Draft
Conversation
The PascalCase rename missed the .agr (agent grammar) files, causing agc compilation failures in CI. Updated all actionName values in 5 .agr files to match their PascalCase counterparts in the TypeScript schemas. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Phase 2 unit test project with three test classes: - CommandDispatcherTests: quit detection, routing, error isolation, empty/unknown commands - AudioCommandHandlerTests: volume set/restore, mute on/off, invalid input handling - HandlerRegistrationTests: all 77 commands registered, no duplicates, PascalCase enforced Uses xUnit + Moq for mocking IAudioService and other internal interfaces. Added InternalsVisibleTo for test project and DynamicProxyGenAssembly2. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Runs dotnet test for autoShell.Tests after the MSBuild build step, in both Debug and Release configurations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fba483e to
b450c9d
Compare
Add explicit this. prefix to all instance field accesses, property accesses, and method calls across 19 files in the autoShell project to comply with .editorconfig rules: - dotnet_style_qualification_for_field = true:error - dotnet_style_qualification_for_property = true:error - dotnet_style_qualification_for_method = true:error - dotnet_style_qualification_for_event = true:error Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Structural refactoring of
autoShellto make the codebase testable, maintainable, and extensible. No behavior changes — all 78 commands continue to work identically.Phase 1: Structural Refactoring (Make It Testable)
IAudioService,IRegistryService,ISystemParametersService,IProcessService)AudioCommandHandler,WindowCommandHandler,SettingsCommandHandler, etc.)execLineswitch withCommandDispatcher+ dictionary lookup<inheritdoc/>on implementations.editorconfigrules)Phase 2: Unit Tests
autoShell.TestsxUnit project with MoqAudioCommandHandlerwith mockedIAudioService(18 tests)IRegistryService/ISystemParametersService(14 test classes)AppCommandHandler,ThemeCommandHandler,SystemCommandHandlerwith mocked servicesdotnet testto CIPhase 3: Deep Refactoring
SettingsCommandHandlerinto 9 domain sub-handlers (Taskbar, Display, Mouse, Accessibility, Privacy, Power, FileExplorer, Personalization, SystemSettings)IAppRegistryservice (replaces static fields)AutoShell.csinto handlers (~1429 → ~152 lines)WindowCommandHandler.RaiseWindow,FindProcessWindowHandle)AutoShell_Win32.cs— all declarations now live in handlersDebug.WriteLinewith proper abstraction)dotnet formatCI check