Skip to content

Add GFM Alert Styling - #168

Open
Sam Clark (28pins) wants to merge 4 commits into
microsoft:mainfrom
28pins:28pins-add-alerts
Open

Add GFM Alert Styling#168
Sam Clark (28pins) wants to merge 4 commits into
microsoft:mainfrom
28pins:28pins-add-alerts

Conversation

@28pins

@28pins Sam Clark (28pins) commented Aug 15, 2026

Copy link
Copy Markdown

Summary

What changed: Added support for alerts, like [!NOTE]
Why: to give users and LLMs more flexibility and better UX

API change: BlockQuoteType now includes BlockQuoteAlertKind as an optional. See below:

Old:

text(String)
case nested([BlockQuoteType])

New:

case text(String, BlockQuoteAlertKind?)
case nested([BlockQuoteType], BlockQuoteAlertKind?)

Validation

Checked demos and stress-tested kitchen sink demo

OSS readiness

  • No secrets, internal URLs, private identifiers, or product-only service names were added.
  • Public docs, fixtures, or notices were updated if behavior or dependencies changed.
  • Third-party dependency changes (adds, removes, version bumps) are intentional and reviewed.
  • Streaming/incomplete markdown behavior remains covered by fixtures or tests.

@28pins
Sam Clark (28pins) requested review from a team and a lite review from Copilot August 15, 2026 22:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@28pins
Sam Clark (28pins) requested a lite review from Copilot August 15, 2026 22:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

Suppressed comments (1)

Sources/MarkdownText/UI/BlockQuoteView.swift:104

  • These lines contain tab-indentation, which is likely to trip SwiftLint and makes the new alert view code inconsistent with the surrounding file’s spacing-based indentation.
			Image(systemName: style.imageName)
				.foregroundStyle(style.accentColor)
				.padding(.leading, 8.0)

Comment thread Sources/MarkdownText/Block/BlockQuote+.swift
Comment thread Sources/MarkdownText/UI/BlockQuoteView.swift Outdated
Comment thread Sources/MarkdownText/Models/MarkdownRenderConfig+Builders.swift Outdated
Comment thread Tests/MarkdownTextTests/BlockQuoteViewSnapshotTests.swift
Comment thread Sources/MarkdownText/Resources/Localizable.xcstrings Outdated
@28pins Sam Clark (28pins) changed the title 28pins add alerts Add GFM Alert Styling Sep 1, 2026
Sam Clark (28pins) and others added 2 commits September 1, 2026 18:38
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants