Repository navigation
FIX: Handle missing prompt keys gracefully in write_txt - #3378
Open
Manohar Paturi (ManoharPaturi) wants to merge 3 commits into
Open
Manohar Paturi (ManoharPaturi) wants to merge 3 commits into
Manohar Paturi (ManoharPaturi) wants to merge 3 commits into
Conversation
Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3377
The write_txt helper previously looked up ex["prompt"] directly when serializing prompt dictionaries. If an item in the examples list was an empty dictionary or lacked a prompt key, the call crashed with a KeyError. This change safely extracts prompt values with ex.get("prompt") and falls back to an empty string so that empty entries and dictionaries with alternative metadata fields serialize cleanly.
Tests and Documentation
Added unit tests in test_text_helper.py covering basic serialization, empty inputs, roundtrip parsing with read_txt, and handling rows with missing or None prompt values.
No documentation change needed, so I did not run JupyText.