Repository navigation
FIX: Add YAML and JSONL extension mappings to get_mime_type - #3376
Open
Manohar Paturi (ManoharPaturi) wants to merge 3 commits into
Open
Manohar Paturi (ManoharPaturi) wants to merge 3 commits into
Manohar Paturi (ManoharPaturi) wants to merge 3 commits into
Conversation
Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3375
The get_mime_type utility provides an explicit mapping in _EXTENSION_TO_MIME_TYPE for common file extensions. Because standard library mimetypes.guess_type does not register yaml, yml, or jsonl by default on many platforms, calling get_mime_type on YAML templates or JSON Lines datasets returned None. This change adds explicit mappings for yaml and yml to application/yaml and jsonl to application/jsonlines so that media type resolution works consistently across all operating systems.
Tests and Documentation
Updated tests in test_mime_type.py to verify that yaml, yml, and jsonl extensions resolve to their expected MIME types without invoking the fallback resolver.
No documentation change needed, so I did not run JupyText.