Repository navigation
FIX: Include endpoint and method in HTTPXAPITarget identifier - #3374
Open
Manohar Paturi (ManoharPaturi) wants to merge 3 commits into
Open
Manohar Paturi (ManoharPaturi) wants to merge 3 commits into
Manohar Paturi (ManoharPaturi) wants to merge 3 commits into
Conversation
Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3373
HTTPXAPITarget previously delegated raw request setup to HTTPTarget with an empty string, causing the target endpoint to remain an empty string. It also inherited HTTPTarget._build_identifier without overriding it, leaving prompt_regex_string and use_tls while omitting method and http2. This change sets the endpoint and destination origin to the configured http_url and implements _build_identifier to capture method, follow_redirects, callback_function, and http2 so that distinct API targets produce distinct identifiers.
Tests and Documentation
Added unit tests in test_http_api_target.py verifying that HTTPXAPITarget populates its endpoint and method parameters properly, and that distinct endpoints and methods produce distinct identifier hashes.
No documentation change needed, so I did not run JupyText.