Skip to content

TEST: Join SQLite cleanup workers before leak checks #3362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Roman Lutz (romanlutz) merged 2 commits into from
Oct 20, 2026
Merged

TEST: Join SQLite cleanup workers before leak checks #3362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dd8a79
TEST: Join SQLite cleanup workers before leak checks
richlundeen Oct 19, 2026
dd4f62d
Merge branch 'main' into richlundeen-sqlite-fixture-cleanup
romanlutz Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions tests/unit/memory/test_sqlite_fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,12 +242,16 @@ async def test_sqlite_instance_cleans_up_on_failure(
_assert_closed(sqlite_connections)


async def test_sqlite_instance_does_not_retain_process_exit_cleanup(sqlite_template: sqlite3.Connection) -> None:
async with _sqlite_instance(sqlite_template=sqlite_template) as memory:
assert memory.cleanup.__func__ is MemoryInterface.cleanup
assert "cleanup" not in memory.__dict__
memory_reference = weakref.ref(memory)
del memory
def test_sqlite_instance_does_not_retain_process_exit_cleanup(sqlite_template: sqlite3.Connection) -> None:
async def release_memory_async() -> weakref.ReferenceType[SQLiteMemory]:
async with _sqlite_instance(sqlite_template=sqlite_template) as memory:
assert memory.cleanup.__func__ is MemoryInterface.cleanup
assert "cleanup" not in memory.__dict__
return weakref.ref(memory)

# Disposal's future can finish before its worker releases the bound method.
with asyncio.Runner() as runner:
memory_reference = runner.run(release_memory_async())
gc.collect()
assert memory_reference() is None

Expand Down
Loading