Repository navigation
MAINT: Store hash in prompt template identifiers - #3340
Open
Isaac Emmanuel (1cbyc) wants to merge 6 commits into
Open
Isaac Emmanuel (1cbyc) wants to merge 6 commits into
Isaac Emmanuel (1cbyc) wants to merge 6 commits into
Conversation
Co-authored-by: insisong <emmanuelisaacnsisong@gmail.com>
Check the long-template identifier's serialized form instead of str(), which never includes params, and pin its template_hash. Pin the PromptTemplateConverter identifier hash, and assert TaskFramingConverter emits no template_hash and keeps its v1.1.0 hash. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 170f6a4a-a2dd-481d-a201-8cbf40b3d566
hannahwestra25
approved these changes
Oct 19, 2026
hannahwestra25
left a comment
hannahwestra25
left a comment
Contributor
There was a problem hiding this comment.
thanks for contributing! made a few changes to make the test assertions stricter jfyi
PromptTemplateConverter has not shipped in a release, so its class docstring should not describe a one-time identifier change for existing configurations. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 170f6a4a-a2dd-481d-a201-8cbf40b3d566
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 20, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 20, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 20, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3339.
Replace the full configured template in
PromptTemplateConverteridentifier params with the project-standard 16-character SHA-256 content hash. This keeps identifier metadata fixed-size while preserving deterministic identity across equivalent templates and distinct identity across different templates orstrip_characterssettings.The converter documentation notes the one-time identifier hash and autogenerated registry-name change. Conversion output is unchanged, and deprecated
TaskFramingConverteridentifiers retain their legacy representation.Tests and Documentation
61 passed, 30 skippedfor the focused prompt-template and task-framing converter suitestysource check forprompt_template_converter.pygit diff --checkCo-authored-by: insisong emmanuelisaacnsisong@gmail.com