FIX Make conversation panel and attack history rows keyboard-accessible#1990
Merged
hannahwestra25 merged 3 commits intoJun 12, 2026
Merged
Conversation
ConversationPanel and AttackTable rows were clickable but unreachable by keyboard. Add tabIndex, role/aria-label, and Enter/Space onKeyDown handlers so keyboard users can select conversations and open attacks, with matching focus-visible outlines. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jsong468
approved these changes
Jun 10, 2026
jsong468
reviewed
Jun 10, 2026
romanlutz
approved these changes
Jun 11, 2026
Addresses review feedback on PR microsoft#1990 — the new keyboard-accessibility test for AttackTable was using fireEvent.keyDown, but per frontend-test.instructions.md user interactions should use @testing-library/user-event. Switched to user.keyboard with focused row. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two clickable surfaces in the GUI were unreachable by keyboard:
ConversationPanel— conversation rows were a plain<div onClick=…>with norole,tabIndex, or key handler, so keyboard-only users could not select a conversation.AttackTable— the history<TableRow>was clickable for mouse but had no keyboard affordance on the row itself.Changes
tabIndex={0},aria-label, and anonKeyDownhandler (Enter / Space activate) to both elements.ConversationPanelrow also getsrole=\"button\"andaria-currentfor selection state, since it's a<div>. Fluent'sTableRowkeeps its native row semantics, so I did not override its role there.:focus-visibleoutline on both row styles so the focus ring is visible.Validation
npx jeston both touched suites → 34/34 passnpx eslinton touched files → cleannpx tsc --noEmit→ cleannpm test→ 650/651 pass; single failure was a pre-existing flake inCreateTargetDialog.test.tsx(passes in isolation, unrelated to these files)