Draft
Conversation
Enhanced the project by embedding backdoor rule JSON files as `EmbeddedResource` items in `Shared.CLI.csproj`, allowing runtime access without file system dependency. Updated `CharacteristicTool.cs` to support embedded rules in `AnalyzeFile`, `AnalyzeDirectory`, and `AnalyzePackage` methods, and added `AnalyzeDirectoryRaw` for raw match records. Refactored `DetectBackdoorTool.cs` to load rules directly from assembly resources, removing the `RULE_DIRECTORY` property. Introduced new methods for package and directory analysis, improving flexibility and reducing external file reliance.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot generated
This pull request refactors the
DetectBackdoorToolto improve how backdoor detection rules are loaded and used, transitioning from loading rules from the file system to using embedded resources. This makes rule management more robust and simplifies deployment. Additionally, the detection workflow and result display logic have been modernized for clarity and maintainability.Backdoor rule loading and resource management:
Resources\BackdoorRulesare now included as embedded resources in theShared.CLI.csprojfile, replacing previous content-only inclusion. This allows the application to load rules directly from the assembly rather than the file system.RULE_DIRECTORYproperty and related filesystem-based rule loading logic have been removed fromDetectBackdoorTool, and replaced with a newLoadEmbeddedRules()method that loads all embedded rule files at runtime.Detection workflow and result display improvements:
RunAsyncmethod now validates targets, loads embedded rules, and processes each target (package URL, directory, or file) with improved error handling and logging.