Add ReferenceCopyLocalPaths to csproj to find implementation dll for …#217
Add ReferenceCopyLocalPaths to csproj to find implementation dll for …#217adamtuliper wants to merge 2 commits intomicrosoft:masterfrom
Conversation
|
@adamtuliper This PR looks like it contains more than is mentioned in the description. Was that intentional? |
carmines
left a comment
carmines
left a comment
There was a problem hiding this comment.
remove any binaries, we do not want these to be part of the official build. Devs should be building their own .dll's
For Unity, check-in the meta file that correctly set the .dll properties for the UWP and WIn32 binaries correctly
| <SpecificVersion>False</SpecificVersion> | ||
| <HintPath>$(SolutionDir)..\..\..\Build\$(Configuration)\Plugins\WSA\$(PlatformName)\MixedRemoteViewCompositor.winmd</HintPath> | ||
| <Reference Include="MixedRemoteViewCompositor"> | ||
| <HintPath>..\..\..\..\Source\Win32\MixedRemoteViewCompositor.winmd</HintPath> |
There was a problem hiding this comment.
modify the path to the repo's build folder "$(SolutionDir)......\Build$(Configuration)\Plugins".
| <TargetPlatformVersion>10.0.10586.0</TargetPlatformVersion> | ||
| <TargetPlatformMinVersion>10.0.10240.0</TargetPlatformMinVersion> | ||
| <TargetPlatformVersion>10.0.16299.0</TargetPlatformVersion> | ||
| <TargetPlatformMinVersion>10.0.16299.0</TargetPlatformMinVersion> |
There was a problem hiding this comment.
HoloLens OS is 14393 RS1 and RS4 only. Check your builds run on both
| @@ -1,2 +1 @@ | |||
| m_EditorVersion: 5.4.0b24-HTP | |||
| m_StandardAssetsVersion: 0 | |||
| m_EditorVersion: 2017.2.0p2 | |||
There was a problem hiding this comment.
ensure the check-in works against 2017.4 LTS build for RS4
| Microsoft Visual Studio Solution File, Format Version 12.00 | ||
| # Visual Studio 14 | ||
| VisualStudioVersion = 14.0.25420.1 | ||
| # Visual Studio 15 |
There was a problem hiding this comment.
there are additional changes needed for x64, latest SDK and to build correctly without warnings for 2017. See my repo for a version that compiles cleanly:
https://github.com/carmines/MixedRealityCompanionKit/tree/master/MixedRemoteViewCompositor
3 participants
This should resolve the "implementation file not found" issue in #199
Since the MixedRemoteViewCompositor reference is set CopyLocal=true, we can use the to point to the dll.
I believe we can also leave SpecificVersion=false out, since it looks like Visual Studio defaults to SpecificVersion=false if we don't have a version/culture on the reference.