WIP: Prepare Experiment.load to handle async out of order trial completion#973
Draft
bpkroth wants to merge 132 commits intomicrosoft:mainfrom
Draft
WIP: Prepare Experiment.load to handle async out of order trial completion#973bpkroth wants to merge 132 commits intomicrosoft:mainfrom
bpkroth wants to merge 132 commits intomicrosoft:mainfrom
Conversation
…r some reuse by ParallelTrialScheduler
for more information, see https://pre-commit.ci
…prepare-exp-load-to-handle-async-trials
…prepare-exp-load-to-handle-async-trials
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This reverts commit 4225862.
…exp-load-to-handle-async-trials
for more information, see https://pre-commit.ci
…e-exp-load-to-handle-async-trials
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…e-exp-load-to-handle-async-trials
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Title
Prepare
Experiment.loadto handle async out of order trial completionDescription
In the case of
ParallelTrialScheduler(#971) where Trials may complete out of order relative to what they were submitted in, we can no longer rely only on_last_trial_idto fetch the latest Trial results when registering finished Trial scores with the Optimizer since that may cause us to skip trial_ids that are less than that that haven't completed yet.This change enables us to handle that situation by doing the following:
set()ofregistered_trial_idsand allow omitting them from being returned by theExperiment.load()operation.trial_idin the Experiment. This allows us to remove alltrial_ids < first_unfinished_trial_idfrom theregistered_trial_idsset.Needs tests.
Split changes out
Type of Change
Testing
Additional Notes (optional)
This should have no impact on the
SyncScheduler.