Include final retain in tree deltas - #27809
Open
CraigMacomber wants to merge 4 commits into
Open
Conversation
…ug with last new line
github-actions
Bot
added
base: main
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (488 lines, 12 files), I've queued these reviewers:
How this works
|
Josmithr
reviewed
Jul 31, 2026
Josmithr
reviewed
Jul 31, 2026
Josmithr
reviewed
Jul 31, 2026
Josmithr
reviewed
Jul 31, 2026
Josmithr
reviewed
Jul 31, 2026
CraigMacomber
added a commit
that referenced
this pull request
Jul 31, 2026
## Description While authoring #27809 I had to make some assumptions about deltas, which were undocumented. This fills in the missing documentation.
Contributor
|
wait for #27824 to merge |
Contributor
Bundle size comparisonBase commit: Notable changesNo bundles changed by ≥ 500 bytes parsed. Per-bundle deltas
|
Josmithr
reviewed
Aug 4, 2026
| } | ||
|
|
||
| // Fixup required new line: quill requires one at the end, so we add an extra if needed. | ||
| // This simple deletes the old one if there was one, then adds a new one if needed. |
Contributor
There was a problem hiding this comment.
Suggested change
| // This simple deletes the old one if there was one, then adds a new one if needed. | |
| // This simply deletes the old one if there was one, then adds a new one if needed. |
Josmithr
reviewed
Aug 4, 2026
Comment on lines
+332
to
+333
| // This hits an edge case in the quill integration since quill requires such a trailing line end, | ||
| // so our integration replaces its extra one it had to add to support will with the real one added by this change. |
Contributor
There was a problem hiding this comment.
There are some typos here.
Josmithr
reviewed
Aug 4, 2026
Josmithr
left a comment
Josmithr
left a comment
Contributor
There was a problem hiding this comment.
Left a couple of comments for docs typos. Otherwise, looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously our array node deltas were not required to include the final retain. This is now alwayse included.
Addationally handling of the extra new line required to make quill a happe is now more robust, fixing a buig where remote copllaborators should end up with extra new lines.
Reviewer Guidance
The review process is outlined on this wiki page.