build(r11s): bump @types/node to ^22, upgrade zookeeper to ^7, and update webpack#26493
build(r11s): bump @types/node to ^22, upgrade zookeeper to ^7, and update webpack#26493tylerbutler merged 3 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR performs a comprehensive upgrade of Node.js type definitions and key build dependencies across the routerlicious server workspace. The changes modernize the dependency stack by bumping @types/node from v18 to v22, upgrading zookeeper from v5 to v7, and updating webpack to the latest v5.105.2.
Changes:
- Removed restrictive
@types/nodeversion overrides that were constraining the workspace to v18/v20 types - Updated all 14 packages to use
@types/node@^22for consistency with modern Node.js - Upgraded
zookeeperdependency from^5.3.2to^7.2.0with a workspace-level override to prevent regressions from older versions - Bumped
webpackfrom^5.94.0to^5.105.2in build-related packages
Reviewed changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| server/routerlicious/package.json | Removed @types/node version overrides, added zookeeper override to ^7.2.0, updated comments |
| server/routerlicious/pnpm-lock.yaml | Lockfile updates reflecting all dependency version changes and transitive dependency resolutions |
| server/routerlicious/packages/*/package.json (14 files) | Updated @types/node from ^18.19.39 to ^22 across all packages |
| server/routerlicious/packages/lambdas/package.json | Updated webpack from ^5.94.0 to ^5.105.2 |
| server/routerlicious/packages/local-server/package.json | Updated webpack from ^5.94.0 to ^5.105.2 |
| server/routerlicious/packages/memory-orderer/package.json | Updated webpack from ^5.94.0 to ^5.105.2 |
| server/routerlicious/packages/services-ordering-zookeeper/package.json | Updated zookeeper from ^5.3.2 to ^7.2.0 |
a1fd5ff to
835062e
Compare
alexvy86
left a comment
There was a problem hiding this comment.
Look good as prep work to enable the node22 build, just one comment below.
| "@types/nconf": "^0.10.0", | ||
| "@types/node": "^18.19.39", | ||
| "@types/node": "^22", | ||
| "@types/rimraf": "^3.0.0", |
There was a problem hiding this comment.
rimraf now comes with its own types so we shouldn't need to add this. Maybe a bad merge resolution after merging a change by Matt to update rimraf and remove the deps on its types package?
|
I'll address the rimraf addition in a follow up pr. |
Summary
@types/nodefrom^18.19.39to^22across all routerlicious packages@types/nodeversion overrides that were constraining ranges (@types/node@<18and@types/node@>=22)zookeeperfrom^5.3.2to^7.2.0inservices-ordering-zookeeper, with a workspace-level override to pin^7.2.0since earlier versions fail to compilewebpackfrom^5.94.0to^5.105.2inlambdas,local-server, andmemory-orderer