Skip to content

build(r11s): bump @types/node to ^22, upgrade zookeeper to ^7, and update webpack#26493

Merged
tylerbutler merged 3 commits intomainfrom
r11s-zookeeper-node-types
Feb 20, 2026
Merged

build(r11s): bump @types/node to ^22, upgrade zookeeper to ^7, and update webpack#26493
tylerbutler merged 3 commits intomainfrom
r11s-zookeeper-node-types

Conversation

@tylerbutler
Copy link
Copy Markdown
Member

@tylerbutler tylerbutler commented Feb 19, 2026

Summary

  • Bump @types/node from ^18.19.39 to ^22 across all routerlicious packages
  • Remove the @types/node version overrides that were constraining ranges (@types/node@<18 and @types/node@>=22)
  • Upgrade zookeeper from ^5.3.2 to ^7.2.0 in services-ordering-zookeeper, with a workspace-level override to pin ^7.2.0 since earlier versions fail to compile
  • Bump webpack from ^5.94.0 to ^5.105.2 in lambdas, local-server, and memory-orderer

@tylerbutler tylerbutler changed the title R11s zookeeper node types build(r11s): bump @types/node to ^22, upgrade zookeeper to ^7, and update webpack Feb 19, 2026
@tylerbutler tylerbutler marked this pull request as ready for review February 19, 2026 19:07
Copilot AI review requested due to automatic review settings February 19, 2026 19:07
@tylerbutler tylerbutler requested review from a team, CraigMacomber and alexvy86 February 19, 2026 19:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs a comprehensive upgrade of Node.js type definitions and key build dependencies across the routerlicious server workspace. The changes modernize the dependency stack by bumping @types/node from v18 to v22, upgrading zookeeper from v5 to v7, and updating webpack to the latest v5.105.2.

Changes:

  • Removed restrictive @types/node version overrides that were constraining the workspace to v18/v20 types
  • Updated all 14 packages to use @types/node@^22 for consistency with modern Node.js
  • Upgraded zookeeper dependency from ^5.3.2 to ^7.2.0 with a workspace-level override to prevent regressions from older versions
  • Bumped webpack from ^5.94.0 to ^5.105.2 in build-related packages

Reviewed changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated no comments.

Show a summary per file
File Description
server/routerlicious/package.json Removed @types/node version overrides, added zookeeper override to ^7.2.0, updated comments
server/routerlicious/pnpm-lock.yaml Lockfile updates reflecting all dependency version changes and transitive dependency resolutions
server/routerlicious/packages/*/package.json (14 files) Updated @types/node from ^18.19.39 to ^22 across all packages
server/routerlicious/packages/lambdas/package.json Updated webpack from ^5.94.0 to ^5.105.2
server/routerlicious/packages/local-server/package.json Updated webpack from ^5.94.0 to ^5.105.2
server/routerlicious/packages/memory-orderer/package.json Updated webpack from ^5.94.0 to ^5.105.2
server/routerlicious/packages/services-ordering-zookeeper/package.json Updated zookeeper from ^5.3.2 to ^7.2.0

@tylerbutler tylerbutler force-pushed the r11s-zookeeper-node-types branch from a1fd5ff to 835062e Compare February 20, 2026 00:24
@tylerbutler tylerbutler self-assigned this Feb 20, 2026
Copy link
Copy Markdown
Contributor

@alexvy86 alexvy86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good as prep work to enable the node22 build, just one comment below.

"@types/nconf": "^0.10.0",
"@types/node": "^18.19.39",
"@types/node": "^22",
"@types/rimraf": "^3.0.0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rimraf now comes with its own types so we shouldn't need to add this. Maybe a bad merge resolution after merging a change by Matt to update rimraf and remove the deps on its types package?

@tylerbutler
Copy link
Copy Markdown
Member Author

tylerbutler commented Feb 20, 2026

I'll address the rimraf addition in a follow up pr.

@tylerbutler tylerbutler merged commit d32b101 into main Feb 20, 2026
28 checks passed
@tylerbutler tylerbutler deleted the r11s-zookeeper-node-types branch February 20, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants