Remove current version from type tests #26050
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the "Current version" comment line from auto-generated type test files to reduce confusion and unnecessary file churn during version bumps.
Key changes:
- Modified the type test generation template to exclude the current version comment
- Retained the baseline (previous) version comment for reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the "current version" isn't a relased/stable thing, putting it in the type tests could be a bit confusing, and can become actually wrong once that version is released.
Also including it makes version bumps touch all the type tests and require a lot of review, which doesn't seem useful.
This removes that line from the generated type tests.
Reviewer Guidance
The review process is outlined on this wiki page.