Add severity shape icons and merge the details pane header#663
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves UI clarity and accessibility by introducing distinct shape-based severity icons (usable without color) and by streamlining the details pane header into a single, more space-efficient row with corrected ARIA structure.
Changes:
- Added a shared
SeverityIconmap and applied it to both the log table and details pane (with updated tests). - Introduced global
.level-iconstyling and row-state overrides to keep icons legible in selected/highlighted/forced-colors states. - Merged the details pane header and tab strip, renamed the “Reader” tab to “Details”, and moved “Copy event” out of the tablist.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Unit/EventLogExpert.UI.Tests/LogTable/LogTablePaneLevelClassTests.cs | Updates expectations to pin the new shared severity icon mapping for the log table. |
| tests/Unit/EventLogExpert.UI.Tests/DetailsPane/DetailsPaneTests.cs | Adds/updates tests for the new header layout, ARIA fixes, and severity icon rendering behavior. |
| tests/Unit/EventLogExpert.UI.Tests/Common/SeverityIconTests.cs | Adds new unit tests to pin the shared severity-to-icon CSS class mapping. |
| src/EventLogExpert.UI/wwwroot/app.css | Adds global .level-icon styling and per-severity color classes. |
| src/EventLogExpert.UI/LogTable/LogTablePane.razor.css | Updates selected/highlighted/forced-colors styling to target .level-icon generically. |
| src/EventLogExpert.UI/LogTable/LogTablePane.razor.cs | Switches level-class computation to the shared SeverityIcon map. |
| src/EventLogExpert.UI/LogTable/LogTablePane.razor | Renders severity icons only when a non-empty class is available, applying the new .level-icon wrapper class. |
| src/EventLogExpert.UI/DetailsPane/DetailsPane.razor.css | Refactors header layout styling and removes obsolete severity-dot styles. |
| src/EventLogExpert.UI/DetailsPane/DetailsPane.razor.cs | Removes the old severity-dot mapping helper now replaced by shared icon mapping. |
| src/EventLogExpert.UI/DetailsPane/DetailsPane.razor | Merges header/tab bar, renames the “Reader” tab to “Details”, moves “Copy event” out of the tablist, and renders severity icons via SeverityIcon. |
| src/EventLogExpert.UI/Common/SeverityIcon.cs | Adds the shared severity-to-icon CSS class map consumed by both surfaces. |
| src/EventLogExpert.Runtime/LogTable/ColumnDefaults.cs | Increases the default Level column width to avoid truncation with the new icon + “Information” label. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jschick04
marked this pull request as ready for review
July 23, 2026 03:21
jschick04
force-pushed
the
jschick/severity-icons
branch
from
July 23, 2026 16:36
6a89367 to
eea2753
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two UI improvements to the event table and details pane.
Severity level icons (accessibility)
SeverityIconmap now drives both the log table and the details pane, closing a drift where the table marked Information but the details pane did not..level-iconrow-state override keeps icons legible on selected / highlighted / forced-colors rows.Details pane header
aria-expanded/aria-controls).role="tablist"(it was a non-tab button inside the tablist), an ARIA fix.Tests
SeverityIconmap tests (all 5 levels + null + a distinct-glyph invariant).Delivers ADO Wave 2 62704706 (severity status-icon: shape, not color) plus the details-pane header polish.