Add .NET 6/.NET Core 3.1 targets#1342
Open
lnetrebskii wants to merge 9 commits intomicrosoft:developfrom
Open
Conversation
added 9 commits
October 26, 2022 23:34
1. Updated dependencies. 2. Removed the option "UseLegacyImplementation" because it is deprecated starting WebDriver 4.3 (see also https://www.selenium.dev/blog/2022/legacy-protocol-support/) 3. EdgeOptions setup adjusted to the updated package.
…lpers to support WebDriver v.4
|
Do we know how long this migration to version 6 approval will take place ? |
Contributor
|
Hi @lnetrebskii I will prefer not to merge this Branch to develop and just to keep .NET Core as a separate branch. I see that you remove functionality like Take Screenshot, I use it. I want also to remove things, for example, the whole old WEB logic. I think .NET Core Support is an excellent point to clean up all old things in a new, straight forward branch, that in the future may become the main branch. But not merging, just droping the old code. |
Contributor
|
lnetrebskii Could you please fix merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Support of .NET 6 and .NET Core 3.1 has been added. The projects converted to .NET SDK format.
Issues addressed
All submissions:
Which browsers was this tested on?